Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(340)

Issue 159049: code review 159049: mention arrays of arrays and slices of slices (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 4 months ago by r
Modified:
15 years, 4 months ago
Reviewers:
rsc, gri
CC:
golang-dev
Visibility:
Public.

Description

mention arrays of arrays and slices of slices Fixes issue 113.

Patch Set 1 #

Total comments: 3

Patch Set 2 : code review 159049: mention arrays of arrays and slices of slices #

Patch Set 3 : code review 159049: mention arrays of arrays and slices of slices #

Total comments: 3

Patch Set 4 : code review 159049: mention arrays of arrays and slices of slices #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M doc/go_spec.html View 1 2 3 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 5
r
Hello gri (cc: golang-dev@googlegroups.com), I'd like you to review the following change.
15 years, 4 months ago (2009-11-20 23:25:23 UTC) #1
gri
http://codereview.appspot.com/159049/diff/1/2 File doc/go_spec.html (right): http://codereview.appspot.com/159049/diff/1/2#newcode619 doc/go_spec.html:619: [2][2][2]float64 perhaps add a comment on the last 2 ...
15 years, 4 months ago (2009-11-20 23:31:27 UTC) #2
gri
LGTM http://codereview.appspot.com/159049/diff/1005/6 File doc/go_spec.html (right): http://codereview.appspot.com/159049/diff/1005/6#newcode611 doc/go_spec.html:611: multi-dimensional types. s/types/objects/. http://codereview.appspot.com/159049/diff/1005/6#newcode699 doc/go_spec.html:699: higher-dimensional objects. s/higher/multi/ ...
15 years, 4 months ago (2009-11-20 23:39:37 UTC) #3
rsc
LGTM http://codereview.appspot.com/159049/diff/1005/6 File doc/go_spec.html (right): http://codereview.appspot.com/159049/diff/1005/6#newcode702 doc/go_spec.html:702: Moreover, the inner slices must be allocated (with ...
15 years, 4 months ago (2009-11-20 23:43:13 UTC) #4
r
15 years, 4 months ago (2009-11-20 23:47:17 UTC) #5
*** Submitted as http://code.google.com/p/go/source/detail?r=44699e529c44 ***

mention arrays of arrays and slices of slices

Fixes issue 113.

R=gri, rsc
CC=golang-dev
http://codereview.appspot.com/159049
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b