code review 1590041: go spec: rename "assignment compatible" -> "assignable"

go spec: rename "assignment compatible" -> "assignable"

[gri, 2010-06-07 23:12:24]

Hello r, rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[rsc, 2010-06-07 23:23:53]

compatible could mean so many things; when i'm
reading the spec i never remember what compatible
means.  changing the definition isn't going to help me.

what about shortening "assignment compatible"
to assignable instead?

On Mon, Jun 7, 2010 at 16:12,  <gri@golang.org> wrote:
> Reviewers: r, rsc,
>
> Message:
> Hello r, rsc (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change.
>
>
> Description:
> go spec: rename "assignment compatible" -> "compatible"
> (per r's suggestion)
>
> The notion "compatible" is never used in any other way
> at this point.
>
> Please review this at http://codereview.appspot.com/1590041/show
>
> Affected files:
>  M doc/go_spec.html
>
>
>

[r2, 2010-06-07 23:32:13]

On Jun 7, 2010, at 4:23 PM, Russ Cox wrote:

> compatible could mean so many things; when i'm
> reading the spec i never remember what compatible
> means.  changing the definition isn't going to help me.
> 
> what about shortening "assignment compatible"
> to assignable instead?

I think the point is that your word 'assignable' would be the same meaning as
'compatible'.  There's only one kind of compatibility any more. It shouldn't be
hard to remember.

-rob

[gri, 2010-06-08 00:20:37]

Hello r, rsc (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc1, 2010-06-08 00:26:58]

lgtm if it lgtr

http://codereview.appspot.com/1590041/diff/11001/12001
File doc/go_spec.html (right):

http://codereview.appspot.com/1590041/diff/11001/12001#newcode1328
doc/go_spec.html:1328: ("<code>x</code> is assignable to <code>T</code>") in any
of these cases:
could drop the parenthetical now

http://codereview.appspot.com/1590041/diff/11001/12001#newcode4168
doc/go_spec.html:4168: to the type of the corresponding element of the
function's
s/to the type of the/to the/

[gri, 2010-06-08 00:33:07]

PTAL

http://codereview.appspot.com/1590041/diff/11001/12001
File doc/go_spec.html (right):

http://codereview.appspot.com/1590041/diff/11001/12001#newcode1328
doc/go_spec.html:1328: ("<code>x</code> is assignable to <code>T</code>") in any
of these cases:
On 2010/06/08 00:27:00, rsc1 wrote:
> could drop the parenthetical now
> 
prefer to leave as it is a short form of the precise "assignable to a variable
of type"

http://codereview.appspot.com/1590041/diff/11001/12001#newcode4168
doc/go_spec.html:4168: to the type of the corresponding element of the
function's
On 2010/06/08 00:27:00, rsc1 wrote:
> s/to the type of the/to the/
> 

Done.

[r, 2010-06-08 00:39:02]

LGTM

[gri, 2010-06-08 00:40:31]

*** Submitted as http://code.google.com/p/go/source/detail?r=1b730a31623f ***

go spec: rename "assignment compatible" -> "assignable"

R=r, rsc
CC=golang-dev
http://codereview.appspot.com/1590041