Issue 15880044: Re-enable hazard warnings for setting render targets that are currently bound as SRVs.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 15880044: Re-enable hazard warnings for setting render targets that are currently bound as SRVs. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by Jamie Madill

Modified:
10 years, 6 months ago

Reviewers:
Geoff Lang, Shannon Woods

CC:
angleproject-review_googlegroups.com, Zhenyao Mo

Base URL:
https://code.google.com/p/angleproject/@master

Visibility:
Public.

More Reviews

Description

Re-enable hazard warnings for setting render targets that are currently bound as SRVs. We can manually unset applied textures in SetRenderTargets. This should fix the spurious warnings while still showing a warning on error cases. BUG= R=geofflang@chromium.org, shannonwoods@chromium.org Committed: https://code.google.com/p/angleproject/source/detail?r=297eb16

Patch Set 1 #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+39 lines, -2 lines)			Patch
M	src/libGLESv2/Renderbuffer.h	View	5 chunks	+5 lines, -0 lines	0 comments	Download
M	src/libGLESv2/Renderbuffer.cpp	View	3 chunks	+15 lines, -0 lines	0 comments	Download
M	src/libGLESv2/renderer/Renderer11.cpp	View	2 chunks	+19 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Shannon Woods

LGTM. (Sorry, I thought I'd gotten this one earlier.)

10 years, 6 months ago (2013-10-28 14:58:56 UTC) #3

Jamie Madill

10 years, 6 months ago (2013-10-30 15:27:26 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r297eb16 (presubmit successful).

Expand All Messages | Collapse All Messages