code review 1581041: http: add Head function for making HTTP HEAD requests

http: add Head function for making HTTP HEAD requests

[adg, 2010-06-07 12:07:38]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[rsc, 2010-06-07 19:37:01]

doesn't a head request have to set Method = "HEAD" ?


On Mon, Jun 7, 2010 at 05:07,  <adg@golang.org> wrote:
> Reviewers: rsc,
>
> Message:
> Hello rsc (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change.
>
>
> Description:
> http: add Head function for making HTTP HEAD requests
>
> Please review this at http://codereview.appspot.com/1581041/show
>
> Affected files:
>  M src/pkg/http/client.go
>  M src/pkg/http/client_test.go
>
>
> Index: src/pkg/http/client.go
> ===================================================================
> --- a/src/pkg/http/client.go
> +++ b/src/pkg/http/client.go
> @@ -130,7 +130,6 @@
>        return
>  }
>
> -
>  // Post issues a POST to the specified URL.
>  //
>  // Caller should close r.Body when done reading it.
> @@ -154,6 +153,18 @@
>        return send(&req)
>  }
>
> +// Head issues a HEAD to the specified URL.
> +func Head(url string) (r *Response, err os.Error) {
> +       var req Request
> +       if req.URL, err = ParseURL(url); err != nil {
> +               return
> +       }
> +       if r, err = send(&req); err != nil {
> +               return
> +       }
> +       return
> +}
> +
>  type nopCloser struct {
>        io.Reader
>  }
> Index: src/pkg/http/client_test.go
> ===================================================================
> --- a/src/pkg/http/client_test.go
> +++ b/src/pkg/http/client_test.go
> @@ -28,3 +28,13 @@
>                t.Errorf("Incorrect page body (did not begin with
> User-agent): %q", s)
>        }
>  }
> +
> +func TestClientHead(t *testing.T) {
> +       r, err := Head("http://www.google.com/robots.txt")
> +       if err != nil {
> +               t.Error(err)
> +       }
> +       if _, ok := r.Header["Last-Modified"]; !ok {
> +               t.Error("Last-Modified header not found.")
> +       }
> +}
>
>
>

[adg, 2010-06-07 19:55:00]

Hello rsc (cc: golang-dev@googlegroups.com),

Please take another look.

[adg, 2010-06-07 19:55:38]

Uhm, yes. Oops.

On 7 June 2010 21:36, Russ Cox <rsc@golang.org> wrote:
> doesn't a head request have to set Method = "HEAD" ?
>
>
> On Mon, Jun 7, 2010 at 05:07,  <adg@golang.org> wrote:
>> Reviewers: rsc,
>>
>> Message:
>> Hello rsc (cc: golang-dev@googlegroups.com),
>>
>> I'd like you to review this change.
>>
>>
>> Description:
>> http: add Head function for making HTTP HEAD requests
>>
>> Please review this at http://codereview.appspot.com/1581041/show
>>
>> Affected files:
>>  M src/pkg/http/client.go
>>  M src/pkg/http/client_test.go
>>
>>
>> Index: src/pkg/http/client.go
>> ===================================================================
>> --- a/src/pkg/http/client.go
>> +++ b/src/pkg/http/client.go
>> @@ -130,7 +130,6 @@
>>        return
>>  }
>>
>> -
>>  // Post issues a POST to the specified URL.
>>  //
>>  // Caller should close r.Body when done reading it.
>> @@ -154,6 +153,18 @@
>>        return send(&req)
>>  }
>>
>> +// Head issues a HEAD to the specified URL.
>> +func Head(url string) (r *Response, err os.Error) {
>> +       var req Request
>> +       if req.URL, err = ParseURL(url); err != nil {
>> +               return
>> +       }
>> +       if r, err = send(&req); err != nil {
>> +               return
>> +       }
>> +       return
>> +}
>> +
>>  type nopCloser struct {
>>        io.Reader
>>  }
>> Index: src/pkg/http/client_test.go
>> ===================================================================
>> --- a/src/pkg/http/client_test.go
>> +++ b/src/pkg/http/client_test.go
>> @@ -28,3 +28,13 @@
>>                t.Errorf("Incorrect page body (did not begin with
>> User-agent): %q", s)
>>        }
>>  }
>> +
>> +func TestClientHead(t *testing.T) {
>> +       r, err := Head("http://www.google.com/robots.txt")
>> +       if err != nil {
>> +               t.Error(err)
>> +       }
>> +       if _, ok := r.Header["Last-Modified"]; !ok {
>> +               t.Error("Last-Modified header not found.")
>> +       }
>> +}
>>
>>
>>
>

[rsc1, 2010-06-07 20:07:45]

LGTM

[adg, 2010-06-07 23:28:51]

*** Submitted as http://code.google.com/p/go/source/detail?r=afdfb7c2a0f3 ***

http: add Head function for making HTTP HEAD requests

R=rsc
CC=golang-dev
http://codereview.appspot.com/1581041