Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(604)

Issue 15750047: code review 15750047: plan9: alternative build for libbio changes (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by jas
Modified:
10 years, 5 months ago
Reviewers:
jnj, rsc, golang-dev
CC:
ality, golang-dev
Visibility:
Public.

Description

plan9: alternative build for libbio changes utilizes core Plan 9 libbio implementation by adding the missing macros and functions to a go-specific libbio target.

Patch Set 1 #

Patch Set 2 : diff -r b4c37131e846 https://code.google.com/p/go/ #

Total comments: 1

Patch Set 3 : diff -r f257b02e7ffe https://code.google.com/p/go/ #

Patch Set 4 : diff -r 6ec0276dad0e https://code.google.com/p/go/ #

Patch Set 5 : diff -r 5298d82f682f https://code.google.com/p/go/ #

Patch Set 6 : diff -r 5298d82f682f https://code.google.com/p/go/ #

Patch Set 7 : diff -r 5298d82f682f https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -11 lines) Patch
A include/plan9/bio.h View 1 1 chunk +23 lines, -0 lines 0 comments Download
M src/cmd/dist/build.c View 1 2 3 4 4 chunks +18 lines, -10 lines 0 comments Download
M src/cmd/dist/plan9.c View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A src/libbio/blec.c View 1 2 3 4 1 chunk +51 lines, -0 lines 0 comments Download

Messages

Total messages: 7
jas
plan9: alternative build configuration for new libbio in contrast to the 14604047 change.
10 years, 7 months ago (2013-10-22 06:16:32 UTC) #1
jnj
https://codereview.appspot.com/15750047/diff/30001/src/lib9/bio_plan9.c File src/lib9/bio_plan9.c (right): https://codereview.appspot.com/15750047/diff/30001/src/lib9/bio_plan9.c#newcode9 src/lib9/bio_plan9.c:9: // I think you forgot to remove this comment ...
10 years, 7 months ago (2013-10-22 17:53:27 UTC) #2
rsc
Sorry, but no more plan 9 changes until after Go 1.2 is out.
10 years, 7 months ago (2013-10-22 19:29:38 UTC) #3
jas
I'd like to move src/lib9/bio_plan9.c to src/libbio and extract the functions from bgetc.c and bputc.c. ...
10 years, 5 months ago (2013-12-03 08:14:08 UTC) #4
jas
*** Abandoned ***
10 years, 5 months ago (2013-12-07 00:58:34 UTC) #5
jas
I think this was tagged after an recent sync. I've moved the lib9/bio_ addition back ...
10 years, 5 months ago (2013-12-07 17:23:32 UTC) #6
jas
10 years, 5 months ago (2013-12-07 17:52:42 UTC) #7

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b