Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(188)

Issue 157300043: Support top-level onerror for non-DOM guests. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by kpreid_google
Modified:
11 years, 4 months ago
Reviewers:
felix8a
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

r5701, which introduced a bottleneck function for window.onerror invocations, did not consider the case of guests without DOM. Move domicile.handleUncaughtException to be Domado.handleUncaughtException so that it can be invoked even if there is no domicile object. handleUncaughtException now takes the window (or global/imports) object as an argument, and is not otherwise changed. Arguably it should be moved out of domado.js entirely, but I currently think that it makes the most sense there, since onerror is a browser feature rather than a JS feature, and we do not yet have a "browser features other than the DOM" module. (One reason we might gain such is if we provide setTimeout-and-friends in the no-DOM case, which we probably should.) @r5703

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -66 lines) Patch
M src/com/google/caja/plugin/domado.js View 9 chunks +66 lines, -60 lines 0 comments Download
M src/com/google/caja/plugin/html-emitter.js View 2 chunks +7 lines, -2 lines 0 comments Download
M src/com/google/caja/plugin/ses-frame-group.js View 1 chunk +1 line, -1 line 0 comments Download
M tests/com/google/caja/plugin/test-cajajs-invocation.js View 2 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 4
kpreid_google
11 years, 4 months ago (2014-10-21 19:50:54 UTC) #1
felix8a
lgtm. maybe add a TODO somewhere about factoring out non-DOM browser features?
11 years, 4 months ago (2014-10-21 20:36:49 UTC) #2
kpreid_google
On 2014/10/21 20:36:49, felix8a wrote: > lgtm. maybe add a TODO somewhere about factoring out ...
11 years, 4 months ago (2014-10-21 20:47:50 UTC) #3
kpreid_google
11 years, 4 months ago (2014-10-21 20:58:07 UTC) #4
Message was sent while issue was closed.
On 2014/10/21 20:47:50, kpreid_google wrote:
> I'll file an issue, which I think is more fitting since it's not related to
any
> given piece of code.

https://code.google.com/p/google-caja/issues/detail?id=1857 already existed
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b