Left: | ||
Right: |
LEFT | RIGHT |
---|---|
1 <!-- Contributing to the Go project --> | 1 <!-- Contributing to the Go project --> |
2 | 2 |
3 <h2 id="Introduction">Introduction</h2> | 3 <h2 id="Introduction">Introduction</h2> |
4 | 4 |
5 <p> | 5 <p> |
6 This document explains how to write a new package, | 6 This document explains how to write a new package, |
7 how to test code, and how to contribute changes to the Go project. | 7 how to test code, and how to contribute changes to the Go project. |
8 It assumes you have installed Go using the | 8 It assumes you have installed Go using the |
9 <a href="install.html">installation instructions</a>. (Note that | 9 <a href="install.html">installation instructions</a>. (Note that |
10 the <code>gccgo</code> frontend lives elsewhere; | 10 the <code>gccgo</code> frontend lives elsewhere; |
(...skipping 316 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
327 src/pkg/math/sin.go | 327 src/pkg/math/sin.go |
328 src/pkg/math/tan.go | 328 src/pkg/math/tan.go |
329 src/pkg/regexp/regexp.go | 329 src/pkg/regexp/regexp.go |
330 </pre> | 330 </pre> |
331 | 331 |
332 <p> | 332 <p> |
333 The <code>Reviewer</code> line lists the reviewers assigned | 333 The <code>Reviewer</code> line lists the reviewers assigned |
334 to this change, and the <code>CC</code> line lists people to | 334 to this change, and the <code>CC</code> line lists people to |
335 notify about the change. | 335 notify about the change. |
336 These can be code review nicknames or arbitrary email addresses. | 336 These can be code review nicknames or arbitrary email addresses. |
337 If you don't know who is best to review the change, set the | |
338 reviewer field to the | |
339 <a href="http://groups.google.com/group/golang-dev">golang-dev@googlegroups.com< /a> | |
340 mailing list. | |
337 </p> | 341 </p> |
338 | 342 |
339 <p> | 343 <p> |
340 Replace “<code><enter description here></code>” | 344 Replace “<code><enter description here></code>” |
341 with a description of your change. | 345 with a description of your change. |
342 The first line of the change description is conventionally | 346 The first line of the change description is conventionally |
343 a one-line summary of the change and is used as the | 347 a one-line summary of the change and is used as the |
344 subject for code review mail; the rest of the | 348 subject for code review mail; the rest of the |
345 description elaborates. | 349 description elaborates. |
346 </p> | 350 </p> |
(...skipping 283 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
630 If you are the copyright holder, you will need to agree to | 634 If you are the copyright holder, you will need to agree to |
631 the <a href="http://code.google.com/legal/individual-cla-v1.0.html">individual | 635 the <a href="http://code.google.com/legal/individual-cla-v1.0.html">individual |
632 contributor license agreement</a>, which can be completed online; | 636 contributor license agreement</a>, which can be completed online; |
633 if your organization is the copyright holder, the organization | 637 if your organization is the copyright holder, the organization |
634 will need to agree to the <a href="http://code.google.com/legal/corporate-cla-v1 .0.html">corporate contributor license agreement</a>. | 638 will need to agree to the <a href="http://code.google.com/legal/corporate-cla-v1 .0.html">corporate contributor license agreement</a>. |
635 (If the copyright holder for your code has already completed the | 639 (If the copyright holder for your code has already completed the |
636 agreement in connection with another Google open source project, | 640 agreement in connection with another Google open source project, |
637 it does not need to be completed again.) | 641 it does not need to be completed again.) |
638 <li> | 642 <li> |
639 Send mail, or include information in the change list description, | 643 Send mail, or include information in the change list description, |
640 notifying us how you should | 644 notifying us how you should be represented in the <code>CONTRIBUTORS</code> |
641 be represented in the <code>CONTRIBUTORS</code> and <code>AUTHORS</code> | 645 and <code>AUTHORS</code> files so we can add your information to |
642 files so we can add your information to them. | 646 them. Specifically, tell us either that you've completed the |
rsc
2009/11/24 21:55:57
Specifically, tell us either that you've completed
| |
643 </ol> | 647 individual agreement or tell us the name of your organization once |
648 it has completed the corporate agreement. One of the Go developers | |
649 at Google will add you to <code>CONTRIBUTORS</code> and, if | |
650 appropriate, <code>AUTHORS</code> after verifying that the agreement | |
651 has been completed. We will use the email address you use on | |
652 codereview.appspot.com as the email address in these files.</ol> | |
644 <p> | 653 <p> |
645 This rigamarole needs to be done only for your first submission. | 654 This rigamarole needs to be done only for your first submission. |
646 </p> | 655 </p> |
647 | 656 |
648 <p> | 657 <p> |
649 Once the code is ready to be committed, | 658 Once the code is ready to be committed, |
rsc
2009/11/24 21:55:57
i think you can delete this in favor of the above.
r1
2009/11/24 21:59:25
i don't think so. this says that *we* will do the
| |
650 one of the Go developers at Google will approve and submit | 659 one of the Go developers at Google will approve and submit |
651 your change after checking that the items above have been executed. | 660 your change. |
652 </p> | 661 </p> |
LEFT | RIGHT |