Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(68)

Issue 157123: fix some domita_test failures on opera 10 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 4 months ago by felix8a
Modified:
16 years, 4 months ago
Reviewers:
MikeSamuel
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

This fixes some test failures on Opera 10 http://code.google.com/p/google-caja/issues/detail?id=1141 several tests failed, because color comparisons failed, because when reading a colorname like 'red', Opera gives you the string '"red"'. http://code.google.com/p/google-caja/issues/detail?id=1166 testRowCell failed because it's testing for a specific exception message with assertEquals, but Opera appends some extra info to the end of thte message. http://code.google.com/p/google-caja/issues/detail?id=1167 I'm not sure why the commonJsModule tests were failing, but they're not failing now. with this change, there's only 1 failure remaining on Opera: http://code.google.com/p/google-caja/issues/detail?id=1165 testCustomEvents still fails. I made some changes to report the problem better.

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -17 lines) Patch
M tests/com/google/caja/plugin/domita_test.html View 1 chunk +1 line, -0 lines 0 comments Download
M tests/com/google/caja/plugin/domita_test_untrusted.html View 6 chunks +17 lines, -16 lines 4 comments Download
M tests/com/google/caja/plugin/jsunit.js View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 4
felix8a
16 years, 4 months ago (2009-11-21 09:30:40 UTC) #1
felix8a
oh, wait. the commonJsModule tests are missing, not fail. and they're still missing. so that's ...
16 years, 4 months ago (2009-11-21 09:32:41 UTC) #2
MikeSamuel
LGTM http://codereview.appspot.com/157123/diff/1/4 File tests/com/google/caja/plugin/domita_test_untrusted.html (right): http://codereview.appspot.com/157123/diff/1/4#newcode537 tests/com/google/caja/plugin/domita_test_untrusted.html:537: if (cssColorString === '"' + expected.name+ '"') { ...
16 years, 4 months ago (2009-11-21 16:43:35 UTC) #3
felix8a
16 years, 4 months ago (2009-11-23 22:02:47 UTC) #4

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b