code review 157119: gofmt -r: documentation and minor fixes

gofmt -r: documentation and minor fixes
fix a few paren insertion bugs in the printer too.

[rsc, 2009-11-21 00:44:58]

Hello gri, r (cc: golang-dev@googlegroups.com),

I'd like you to review the following change.

[r, 2009-11-21 00:49:32]

doc.go only:

http://codereview.appspot.com/157119/diff/1004/1005
File src/cmd/gofmt/doc.go (right):

http://codereview.appspot.com/157119/diff/1004/1005#newcode39
src/cmd/gofmt/doc.go:39: pattern -> replacement
maybe quotes around it?

http://codereview.appspot.com/157119/diff/1004/1005#newcode59
src/cmd/gofmt/doc.go:59: gofmt -r 'α[β:len(α)] -> α[β:]' -w $GOROOT/src/pkg
alphas?

[r, 2009-11-21 00:50:26]

http://codereview.appspot.com/157119/diff/1004/1005
File src/cmd/gofmt/doc.go (right):

http://codereview.appspot.com/157119/diff/1004/1005#newcode59
src/cmd/gofmt/doc.go:59: gofmt -r 'α[β:len(α)] -> α[β:]' -w $GOROOT/src/pkg
On 2009/11/21 00:49:33, r wrote:
> alphas?

oh i see. ok

[gri, 2009-11-21 00:59:44]

http://codereview.appspot.com/157119/diff/1004/1006
File src/cmd/gofmt/rewrite.go (right):

http://codereview.appspot.com/157119/diff/1004/1006#newcode84
src/cmd/gofmt/rewrite.go:84: return size == len(s) && unicode.IsLower(rune);
this seems to check for no utf8, and not len == 1

http://codereview.appspot.com/157119/diff/1004/1006#newcode189
src/cmd/gofmt/rewrite.go:189: return subst(nil, old, pos)
should this be old's pos?

[rsc, 2009-11-21 01:25:01]

PTAL

http://codereview.appspot.com/157119/diff/1004/1006
File src/cmd/gofmt/rewrite.go (right):

http://codereview.appspot.com/157119/diff/1004/1006#newcode84
src/cmd/gofmt/rewrite.go:84: return size == len(s) && unicode.IsLower(rune);
On 2009/11/21 00:59:44, gri wrote:
> this seems to check for no utf8, and not len == 1

It checks for size of the first char == size of the string
i.e. the string is just one char.

http://codereview.appspot.com/157119/diff/1004/1006#newcode189
src/cmd/gofmt/rewrite.go:189: return subst(nil, old, pos)
On 2009/11/21 00:59:44, gri wrote:
> should this be old's pos?

It's ignored because m == nil.
I changed the test below to pos != nil since
that is equivalent and clearer.
Also updated the comment.

[gri, 2009-11-21 01:51:49]

LGTM

[rsc, 2009-11-23 23:44:29]

*** Submitted as http://code.google.com/p/go/source/detail?r=0a06788178bc ***

gofmt -r: documentation and minor fixes
fix a few paren insertion bugs in the printer too.

R=gri, r
CC=golang-dev
http://codereview.appspot.com/157119