Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2843)

Issue 157099: code review 157099: archive/tar: Make Reader and Writer more closely follow... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 3 months ago by eds
Modified:
10 years, 2 months ago
Reviewers:
rsc
CC:
golang-dev
Visibility:
Public.

Description

archive/tar: Make Reader and Writer more closely follow io.Reader and io.Writer interfaces There's no functional change here. io gives the Read and Write methods byte slice arguments, but tar called them uint8. It's the same thing, but I think this is clearer and it matches what other packages do.

Patch Set 1 #

Patch Set 2 : code review 157099: archive/tar: Make Reader and Writer more closely follow... #

Patch Set 3 : code review 157099: archive/tar: Make Reader and Writer more closely follow... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/pkg/archive/tar/reader.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/archive/tar/writer.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
eds
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review the following change.
10 years, 3 months ago (2009-11-20 04:32:10 UTC) #1
rsc
LGTM Thanks
10 years, 3 months ago (2009-11-20 04:41:28 UTC) #2
rsc
10 years, 3 months ago (2009-11-20 04:43:32 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=55f876746dae ***

archive/tar: Make Reader and Writer more closely follow io.Reader and io.Writer
interfaces

There's no functional change here. io gives the Read and Write methods byte
slice arguments, but tar called them uint8. It's the same thing, but I think
this is clearer and it matches what other packages do.

R=rsc
CC=golang-dev
http://codereview.appspot.com/157099

Committer: Russ Cox <rsc@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b