Issue 157080044: Work around Firefox 33 regexp performance bug in CSS lexer.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 157080044: Work around Firefox 33 regexp performance bug in CSS lexer. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by kpreid_google

Modified:
11 years, 4 months ago

Reviewers:
MarkM

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

In Firefox 33, regexp operations on strings which can be represented as Latin-1 characters only may be very slow or hung. Work around this for our CSS lexer by inserting a funny character temporarily. This change is based on a patch provided by James Keane, with additional explanatory text and rearrangement of the existing code. The browser bug is expected to be fixed in Firefox 34. https://code.google.com/p/google-caja/issues/detail?id=1941 https://bugzilla.mozilla.org/show_bug.cgi?id=1081175 @r5702

Patch Set 1 #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -3 lines)			Patch
	M	src/com/google/caja/plugin/csslexer.js	View		1 chunk	+12 lines, -3 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages