Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(20)

Issue 157079: Error message and test cleanup (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 5 months ago by MikeSamuel
Modified:
16 years, 5 months ago
Reviewers:
DavidSarah, metaweta
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Changes error messages so they make sense both from linter and from cajoler.. And make some test code available to the ancillary tools. Fix a semicolon warning issue after labeled blocks as in foo: {} Add class=nocode to HTML error snippets so the filename is not prettified. Submitted @3856

Patch Set 1 #

Total comments: 2

Patch Set 2 : Error message and test cleanup #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -45 lines) Patch
M build.xml View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/com/google/caja/cajita-module.js View 1 2 chunks +1 line, -1 line 0 comments Download
M src/com/google/caja/parser/html/HtmlQuasiBuilder.java View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/com/google/caja/parser/js/LabeledStmtWrapper.java View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/com/google/caja/parser/js/Operation.java View 1 3 chunks +44 lines, -0 lines 3 comments Download
M src/com/google/caja/parser/js/Parser.java View 1 2 chunks +4 lines, -3 lines 0 comments Download
M src/com/google/caja/plugin/PluginMessageType.java View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/com/google/caja/render/JsMinimalPrinter.java View 1 1 chunk +1 line, -1 line 0 comments Download
M src/com/google/caja/reporting/HtmlSnippetProducer.java View 1 1 chunk +1 line, -1 line 0 comments Download
M src/com/google/caja/util/Maps.java View 1 2 chunks +37 lines, -2 lines 0 comments Download
M tests/com/google/caja/opensocial/DefaultGadgetRewriterTest.java View 1 2 chunks +2 lines, -1 line 0 comments Download
M tests/com/google/caja/parser/js/ExpressionTest.java View 1 2 chunks +27 lines, -0 lines 0 comments Download
M tests/com/google/caja/plugin/CssValidatorTest.java View 1 13 chunks +13 lines, -13 lines 0 comments Download
M tests/com/google/caja/reporting/HtmlSnippetProducerTest.java View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/com/google/caja/service/FetchedDataTest.java View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tests/com/google/caja/service/TestHttpServletRequest.java View 1 5 chunks +25 lines, -11 lines 0 comments Download
M tests/com/google/caja/service/TestHttpServletResponse.java View 1 5 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 4
MikeSamuel
16 years, 5 months ago (2009-11-19 02:22:18 UTC) #1
metaweta
LGTM http://codereview.appspot.com/157079/diff/1/12 File src/com/google/caja/parser/js/Operation.java (right): http://codereview.appspot.com/157079/diff/1/12#newcode681 src/com/google/caja/parser/js/Operation.java:681: //long l = (long) n; remove old code ...
16 years, 5 months ago (2009-11-19 23:23:31 UTC) #2
DavidSarah
http://codereview.appspot.com/157079/diff/40/1011 File src/com/google/caja/parser/js/Operation.java (right): http://codereview.appspot.com/157079/diff/40/1011#newcode681 src/com/google/caja/parser/js/Operation.java:681: return (int) n; I think this is incorrect. ToInt32 ...
16 years, 5 months ago (2009-11-20 05:04:59 UTC) #3
MikeSamuel
16 years, 5 months ago (2009-11-20 07:34:25 UTC) #4
http://codereview.appspot.com/157079/diff/40/1011
File src/com/google/caja/parser/js/Operation.java (right):

http://codereview.appspot.com/157079/diff/40/1011#newcode681
src/com/google/caja/parser/js/Operation.java:681: return (int) n;
Good catch.  I forgot Infinities are treated as integer 0 in ES instead of
Integer.MIN_VALUE and Integer.MAX_VALUE.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b