Issue 157044: code review 157044: runtime: do not create new threads during malloc.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 157044: code review 157044: runtime: do not create new threads during malloc. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 5 months ago by rsc

Modified:
15 years, 5 months ago

Reviewers:
agl1

CC:
golang-dev

Visibility:
Public.

Description

runtime: do not create new threads during malloc. the signal handling stack is a different size than the normal stack, so it cannot be allocated using the backup stack allocator. Fixes issue 250.

Patch Set 1 #

Patch Set 2 : code review 157044: runtime: do not create new threads during malloc. #

Patch Set 3 : code review 157044: runtime: do not create new threads during malloc. #

Created: 15 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	src/pkg/runtime/proc.c	View		2 chunks	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello agl1 (cc: golang-dev@googlegroups.com), I'd like you to review the following change.

15 years, 5 months ago (2009-11-17 21:02:01 UTC) #1

rsc

15 years, 5 months ago (2009-11-17 22:42:09 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=6c71581bab25 ***

runtime: do not create new threads during malloc.
	the signal handling stack is a different size than
	the normal stack, so it cannot be allocated using
	the backup stack allocator.

Fixes issue 250.

R=agl1
CC=golang-dev
http://codereview.appspot.com/157044

Expand All Messages | Collapse All Messages