Issue 15690047: Do not allow context sharing between egl Displays.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 15690047: Do not allow context sharing between egl Displays. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by Jamie Madill

Modified:
10 years, 6 months ago

Reviewers:
Geoff Lang, Shannon Woods

CC:
angleproject-review_googlegroups.com, Zhenyao Mo

Base URL:
https://code.google.com/p/angleproject/@master

Visibility:
Public.

More Reviews

Description

Do not allow context sharing between egl Displays. This is an explicit error according to the EGL specification. ANGLEBUG=487 BUG= Test=WebGL CTS R=geofflang@chromium.org, shannonwoods@chromium.org Committed: https://code.google.com/p/angleproject/source/detail?r=b4e0003

Patch Set 1 #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -2 lines)			Patch
	M	src/libEGL/libEGL.cpp	View		1 chunk	+9 lines, -1 line	0 comments	Download
	M	src/libGLESv2/Context.h	View		2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Shannon Woods

On 2013/10/22 19:14:59, Jamie Madill wrote: > Please take a look! LGTM.

10 years, 6 months ago (2013-10-23 15:07:41 UTC) #2

Jamie Madill

10 years, 6 months ago (2013-10-23 17:58:19 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as rb4e0003 (presubmit successful).

Expand All Messages | Collapse All Messages