src/pkg/strconv/atoi.go - Issue 156115: code review 156115: gofmt -r 'α[β:len(α)] -> α[β:]' -w src/cmd src/pkg

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/pkg/strconv/atoi.go

Issue 156115: code review 156115: gofmt -r 'α[β:len(α)] -> α[β:]' -w src/cmd src/pkg (Closed)

Patch Set: code review 156115: gofmt -r 'α[β:len(α)] -> α[β:]' -w src/cmd src/pkg Created 15 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: src/pkg/strconv/atoi.go

===================================================================

--- a/src/pkg/strconv/atoi.go

+++ b/src/pkg/strconv/atoi.go

@@ -56,7 +56,7 @@

switch {

case s[0] == '0' && len(s) > 1 && (s[1] == 'x' || s[1] == 'X'):

b = 16;

- s = s[2:len(s)];

+ s = s[2:];

if len(s) < 1 {

err = os.EINVAL;

goto Error;

@@ -140,10 +140,10 @@

s0 := s;

neg := false;

if s[0] == '+' {

- s = s[1:len(s)]

+ s = s[1:]

} else if s[0] == '-' {

neg = true;

- s = s[1:len(s)];

+ s = s[1:];

}

// Convert unsigned and check range.

« no previous file with comments | « src/pkg/regexp/regexp.go ('k') | src/pkg/strconv/atoi_test.go » ('j') | no next file with comments »