Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(795)

Issue 156089: code review 156089: Allow optional second expression in slice expressions. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 8 months ago by gri
Modified:
7 years, 8 months ago
Reviewers:
r, rsc, iant
Visibility:
Public.

Description

Allow optional second expression in slice expressions. Built-in function copy. Addresses issue 203.

Patch Set 1 #

Patch Set 2 : code review 156089: Allow optional second expression in slice expressions. #

Patch Set 3 : code review 156089: Allow optional second expression in slice expressions. #

Total comments: 2

Patch Set 4 : code review 156089: Allow optional second expression in slice expressions. #

Total comments: 14

Patch Set 5 : code review 156089: Allow optional second expression in slice expressions. #

Patch Set 6 : code review 156089: Allow optional second expression in slice expressions. #

Patch Set 7 : code review 156089: Allow optional second expression in slice expressions. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -21 lines) Patch
M doc/go_spec.html View 1 2 3 4 5 6 6 chunks +60 lines, -21 lines 0 comments Download

Messages

Total messages: 9
gri
Hello go-dev@google.com, I'd like you to review the following change.
7 years, 8 months ago (2009-11-19 01:14:21 UTC) #1
gri
Hello rsc, r, iant, I'd like you to review the following change.
7 years, 8 months ago (2009-11-19 01:29:57 UTC) #2
r
LGTM http://codereview.appspot.com/156089/diff/1003/6 File doc/go_spec.html (right): http://codereview.appspot.com/156089/diff/1003/6#newcode2343 doc/go_spec.html:2343: indexes starting at 0 and length equal to ...
7 years, 8 months ago (2009-11-19 01:41:37 UTC) #3
iant
LGTM Besides the below, you have to add copy to the list of predeclared identifiers. ...
7 years, 8 months ago (2009-11-19 01:57:56 UTC) #4
rsc
http://codereview.appspot.com/156089/diff/10/1005 File doc/go_spec.html (right): http://codereview.appspot.com/156089/diff/10/1005#newcode2349 doc/go_spec.html:2349: a := [4]int{1, 2, 3, 4, 5}; s/[4]/[5]/ http://codereview.appspot.com/156089/diff/10/1005#newcode2358 ...
7 years, 8 months ago (2009-11-19 02:01:15 UTC) #5
gri
PTAL http://codereview.appspot.com/156089/diff/10/1005 File doc/go_spec.html (right): http://codereview.appspot.com/156089/diff/10/1005#newcode2344 doc/go_spec.html:2344: <code>hi</code>&nbsp;-<code>&nbsp;lo</code>. On 2009/11/19 01:57:56, iant wrote: > Put ...
7 years, 8 months ago (2009-11-19 02:09:14 UTC) #6
iant
LGTM Still missing copy in list of predeclared identifiers, though, right?
7 years, 8 months ago (2009-11-19 02:13:26 UTC) #7
rsc
LGTM
7 years, 8 months ago (2009-11-19 02:14:34 UTC) #8
gri
7 years, 8 months ago (2009-11-19 03:15:31 UTC) #9
*** Submitted as http://code.google.com/p/go/source/detail?r=b8d347e429d9 ***

Allow optional second expression in slice expressions.
Built-in function copy.
Addresses issue 203.

R=rsc, r, iant
http://codereview.appspot.com/156089
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted