Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(709)

Issue 156051: crypto/rsa: add PKCS#1 v1.5 signature support. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years ago by agl1
Modified:
13 years ago
Reviewers:
rsc
CC:
golang-dev
Visibility:
Public.

Description

crypto/rsa: add PKCS#1 v1.5 signature support.

Patch Set 1 #

Patch Set 2 : code review 156051: crypto/rsa: add PKCS#1 v1.5 signature support. #

Total comments: 12

Patch Set 3 : code review 156051: crypto/rsa: add PKCS#1 v1.5 signature support. #

Patch Set 4 : code review 156051: crypto/rsa: add PKCS#1 v1.5 signature support. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+179 lines, -0 lines) Patch
M src/pkg/crypto/rsa/pkcs1v15.go View 1 2 1 chunk +128 lines, -0 lines 0 comments Download
M src/pkg/crypto/rsa/pkcs1v15_test.go View 1 2 chunks +45 lines, -0 lines 0 comments Download
M src/pkg/crypto/rsa/rsa.go View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4
agl1
13 years ago (2009-11-17 23:24:07 UTC) #1
rsc
LGTM just a few ways to cut the verbosity http://codereview.appspot.com/156051/diff/5/6 File src/pkg/crypto/rsa/pkcs1v15.go (right): http://codereview.appspot.com/156051/diff/5/6#newcode146 src/pkg/crypto/rsa/pkcs1v15.go:146: ...
13 years ago (2009-11-18 02:03:16 UTC) #2
agl1
http://codereview.appspot.com/156051/diff/5/6 File src/pkg/crypto/rsa/pkcs1v15.go (right): http://codereview.appspot.com/156051/diff/5/6#newcode146 src/pkg/crypto/rsa/pkcs1v15.go:146: HashSHA1 PKCS1v15Hash = iota; On 2009/11/18 02:03:16, rsc wrote: ...
13 years ago (2009-11-18 02:21:14 UTC) #3
agl1
13 years ago (2009-11-18 02:21:49 UTC) #4
*** Submitted as http://code.google.com/p/go/source/detail?r=d1b75410b793 ***

crypto/rsa: add PKCS#1 v1.5 signature support.

R=rsc
CC=golang-dev
http://codereview.appspot.com/156051
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b