Issue 156050: Address David-Sarah Hopwood's comments on ScopeAnalyzer

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 156050: Address David-Sarah Hopwood's comments on ScopeAnalyzer (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 7 months ago by MikeSamuel

Modified:
16 years, 7 months ago

Reviewers:
davidsarah.hopwood, ihab.awad

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

I submitted CL 148045 before I addressed http://codereview.appspot.com/148045/diff/5017/6002. This CL addresses those comments. Submitted @3853

Created: 16 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+268 lines, -130 lines)			Patch
M	src/com/google/caja/parser/js/scope/ScopeAnalyzer.java	View	5 chunks	+11 lines, -10 lines	0 comments	Download
M	src/com/google/caja/parser/js/scope/ScopeListener.java	View	2 chunks	+10 lines, -10 lines	0 comments	Download
M	src/com/google/caja/parser/js/scope/ScopeType.java	View	3 chunks	+13 lines, -0 lines	0 comments	Download
M	tests/com/google/caja/parser/js/scope/ScopeAnalyzerTest.java	View	21 chunks	+234 lines, -110 lines	0 comments	Download

Total messages: 2

LGTM