code review 155077: Rework gobs to fix bad bug related to sharing of id's b...

Rework gobs to fix bad bug related to sharing of id's between encoder and decoder side.
Fix is to move all decoder state into the decoder object.

Fixes issue 215.

[r, 2009-11-17 04:35:25]

Hello rsc (cc: golang-dev@google.com),

I'd like you to review the following change.

[r, 2009-11-17 04:38:45]

Hello rsc (cc: golang-dev@google.com),

I'd like you to review the following change.

[rsc, 2009-11-17 07:00:02]

LGTM

the tests got simpler!

http://codereview.appspot.com/155077/diff/1029/18
File src/pkg/gob/decode.go (right):

http://codereview.appspot.com/155077/diff/1029/18#newcode350
src/pkg/gob/decode.go:350: // The encoder engine is an array of instructions
indexed by field number of the incoming
decoder

http://codereview.appspot.com/155077/diff/1029/18#newcode723
src/pkg/gob/decode.go:723: // typeLock must be held.
I think typeLock is unnecessary now.
It was protecting the decoder cache.

http://codereview.appspot.com/155077/diff/1029/18#newcode769
src/pkg/gob/decode.go:769: typeLock.Lock();
That is, I think this call is unnecessary.

http://codereview.appspot.com/155077/diff/1029/20
File src/pkg/gob/encoder.go (right):

http://codereview.appspot.com/155077/diff/1029/20#newcode243
src/pkg/gob/encoder.go:243: switch rt.(type) {
switch rt := rt.(type) {

http://codereview.appspot.com/155077/diff/1029/20#newcode255
src/pkg/gob/encoder.go:255: case *reflect.ArrayType:
can merge into
case reflect.ArrayOrSliceType:
    enc.SendType(rt.Elem());

[r, 2009-11-17 07:32:31]

*** Submitted as http://code.google.com/p/go/source/detail?r=efef35b43491 ***

Rework gobs to fix bad bug related to sharing of id's between encoder and
decoder side.
Fix is to move all decoder state into the decoder object.

Fixes issue 215.

R=rsc
CC=golang-dev
http://codereview.appspot.com/155077