Issue 155049: code review 155049: makefiles: use correct gcc order in case --as-needed is...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 155049: code review 155049: makefiles: use correct gcc order in case --as-needed is... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 5 months ago by rsc

Modified:
15 years, 5 months ago

Reviewers:
r

Visibility:
Public.

Description

makefiles: use correct gcc order in case --as-needed is in use. Suggested by eostapets. Fixes issue 141.

Patch Set 2 : code review 155049: makefiles: use correct gcc order in case --as-needed is... #

Total comments: 1

Patch Set 3 : code review 155049: makefiles: use correct gcc order in case --as-needed is... #

Created: 15 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/Make.pkg	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	src/libcgo/Makefile	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

LGTM http://codereview.appspot.com/155049/diff/1003/4 File src/Make.pkg (right): http://codereview.appspot.com/155049/diff/1003/4#newcode115 src/Make.pkg:115: gcc $(_CGO_CFLAGS_$(GOARCH)) -o $@ $*.cgo4.o $(CGO_LDFLAGS) $(_CGO_LDFLAGS_$(GOOS)) extra ...

15 years, 5 months ago (2009-11-15 16:29:04 UTC) #2

rsc

15 years, 5 months ago (2009-11-15 20:57:29 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=7bdf33ea7bf0 ***

makefiles: use correct gcc order in case --as-needed is in use.

Suggested by eostapets.
Fixes issue 141.

R=r
http://codereview.appspot.com/155049

Expand All Messages | Collapse All Messages