Issue 1548042: code review 1548042: Fix bug 836: "draw.Draw ignores y-coordinate in argumen...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1548042: code review 1548042: Fix bug 836: "draw.Draw ignores y-coordinate in argumen... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 9 months ago by nigeltao

Modified:
14 years, 9 months ago

Reviewers:

CC:
gri, golang-dev

Visibility:
Public.

Description

Fixes issue 836.

Patch Set 1 #

Patch Set 2 : code review 1548042: Fix bug 836: "draw.Draw ignores y-coordinate in argumen... #

Patch Set 3 : code review 1548042: Fixes issue 836. #

Created: 14 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -1 line)			Patch
	M	src/pkg/exp/draw/draw.go	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	src/pkg/exp/draw/draw_test.go	View	1 2	1 chunk	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

nigeltao

Hello gri (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 9 months ago (2010-06-05 00:11:07 UTC) #1

gri

LGTM The CL description should contain the sentence: Fixes issue 836. Exactly as written. This ...

14 years, 9 months ago (2010-06-05 00:25:16 UTC) #2

nigeltao

14 years, 9 months ago (2010-06-05 00:30:51 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=af5741297d26 ***

Fixes issue 836.

R=gri
CC=golang-dev
http://codereview.appspot.com/1548042

Expand All Messages | Collapse All Messages