LGTM Just for your interest, I have been thinking that when the user gives explicit ...
10 years, 6 months ago
(2014-10-22 05:58:54 UTC)
#1
LGTM
Just for your interest, I have been thinking that when the user gives explicit
\voiceOne or \shiftOn to the voices, Lily should set those voices at the shifts
requested, even if two voices have the same shift
<https://codereview.appspot.com/132110043/>
Currently users are required to set 'ignore-note-collision in these cases, but
then that turns off all the other chord-collision code.
https://codereview.appspot.com/154640043/diff/1/Documentation/usage/running.i...
File Documentation/usage/running.itely (right):
https://codereview.appspot.com/154640043/diff/1/Documentation/usage/running.i...
Documentation/usage/running.itely:1112: (@code{\stemDown}, etc) or implicitly
(@code{\voiceOne}, etc.)
People tend to use \stemDown when they want \voiceTwo, so maybe skip mention of
\stemDown.
I wish there were no shorthand for changing just the stem direction without the
other changes required for consistency.
On 2014/10/22 05:58:54, Keith wrote: > Just for your interest, I have been thinking that ...
10 years, 6 months ago
(2014-10-23 09:43:56 UTC)
#2
On 2014/10/22 05:58:54, Keith wrote:
> Just for your interest, I have been thinking that when the user gives explicit
> \voiceOne or \shiftOn to the voices, Lily should set those voices at the
shifts
> requested, even if two voices have the same shift
Not sure I understand this. Doesn't \voiceThree already set the shifts?
> Currently users are required to set 'ignore-note-collision in these cases, but
> then that turns off all the other chord-collision code.
Yes, I don't think we should advocate this.
>
https://codereview.appspot.com/154640043/diff/1/Documentation/usage/running.i...
> Documentation/usage/running.itely:1112: (@code{\stemDown}, etc) or implicitly
> (@code{\voiceOne}, etc.)
> People tend to use \stemDown when they want \voiceTwo, so maybe skip mention
of
> \stemDown.
Agreed. I'll remove \stemDown.
> I wish there were no shorthand for changing just the stem direction without
the
> other changes required for consistency.
It's used 6 times in the LM and 9 times in the NR, and masses of times in the
regression tests. Maybe we should try to reduce the number of times \stemDown
(and Up) is mentioned in the LM and NR.
On Thu, 23 Oct 2014 02:43:56 -0700, <tdanielsmusic@googlemail.com> wrote: > On 2014/10/22 05:58:54, Keith wrote: ...
10 years, 6 months ago
(2014-10-24 02:26:20 UTC)
#4
On Thu, 23 Oct 2014 02:43:56 -0700, <tdanielsmusic@googlemail.com> wrote:
> On 2014/10/22 05:58:54, Keith wrote:
>
>> I have been thinking that when the user gives explicit \voiceOne or \shiftOn
to the voices, Lily should set those voices at the shifts requested, even if two
voices have the same shift
I had forgotten that I already pushed that patch.
> Not sure I understand this. Doesn't \voiceThree already set the shifts?
Yes it does.
I was emphasizing the case where a user sets the same shift on two voices,
because I didn't realize that you had seen the patch that I was thinking of.
Issue 154640043: Doc: Issue 3324: Add explanation of clashing note columns warning
(Closed)
Created 10 years, 6 months ago by Trevor Daniels
Modified 10 years, 6 months ago
Reviewers: Keith
Base URL:
Comments: 1