Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(41)

Issue 154182: Exclude Android-only cpu-features.h from non-Android builds

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 1 month ago by Joel Stanley
Modified:
16 years, 1 month ago
Reviewers:
reed, agl1, agl, piman
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/src/
Visibility:
Public.

Description

Exclude Android-only cpu-features.h from non-Android builds This is needed when building Chromium for ARM. Patch by Joel Stanley <joel@chromium.org>

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 6

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M core/SkBitmapProcState_filter.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M opts/SkBitmapProcState_opts_arm.cpp View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M opts/SkBlitRow_opts_arm.cpp View 1 2 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 6
Joel Stanley
16 years, 1 month ago (2009-11-17 14:19:47 UTC) #1
agl
NACK for now. I need to chat to some people about this first.
16 years, 1 month ago (2009-11-17 16:47:22 UTC) #2
agl1
LGTM. Mike Reed should probably give the final ok. http://codereview.appspot.com/154182/diff/8/1003 File core/SkBitmapProcState_filter.h (right): http://codereview.appspot.com/154182/diff/8/1003#newcode18 core/SkBitmapProcState_filter.h:18: ...
16 years, 1 month ago (2009-11-17 23:39:25 UTC) #3
Joel Stanley
http://codereview.appspot.com/154182/diff/8/1003 File core/SkBitmapProcState_filter.h (right): http://codereview.appspot.com/154182/diff/8/1003#newcode18 core/SkBitmapProcState_filter.h:18: #include <machine/cpu-features.h> On 2009/11/17 23:39:25, agl1 wrote: > Skia ...
16 years, 1 month ago (2009-11-17 23:56:45 UTC) #4
agl
If this is messing up your build, then it's probably ok to land it now. ...
16 years, 1 month ago (2009-11-19 01:06:35 UTC) #5
Joel Stanley
16 years, 1 month ago (2009-11-19 01:15:24 UTC) #6
On 2009/11/19 01:06:35, agl wrote:
> If this is messing up your build, then it's probably ok to land it now. If
Mike
> objects, we can always fix it later.

Thanks, that would be helpful.  Are you able to commit for me?

How do I go about getting it pulled into chrome's tree?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b