Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1094)

Issue 154179: code review 154179: http: do not crash accessing r.Form if ParseForm fails (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 4 months ago by rsc
Modified:
14 years, 4 months ago
Reviewers:
dsymonds
Visibility:
Public.

Description

http: do not crash accessing r.Form if ParseForm fails Fixes issue 233.

Patch Set 1 #

Patch Set 2 : code review 154179: http: do not crash accessing r.Form if ParseForm fails #

Total comments: 1

Patch Set 3 : code review 154179: http: do not crash accessing r.Form if ParseForm fails #

Total comments: 1

Patch Set 4 : code review 154179: http: do not crash accessing r.Form if ParseForm fails #

Patch Set 5 : code review 154179: http: do not crash accessing r.Form if ParseForm fails #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M src/pkg/http/request.go View 1 2 3 4 5 chunks +4 lines, -6 lines 0 comments Download
M src/pkg/http/request_test.go View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5
rsc
Hello dsymonds1, I'd like you to review the following change.
14 years, 4 months ago (2009-11-17 09:07:54 UTC) #1
dsymonds
LGTM http://codereview.appspot.com/154179/diff/3/1002 File src/pkg/http/request.go (right): http://codereview.appspot.com/154179/diff/3/1002#newcode649 src/pkg/http/request.go:649: return "" Perhaps ParseForm above should init r.Form ...
14 years, 4 months ago (2009-11-17 11:37:39 UTC) #2
rsc
PTAL
14 years, 4 months ago (2009-11-17 16:52:04 UTC) #3
dsymonds
LGTM http://codereview.appspot.com/154179/diff/2001/1006 File src/pkg/http/request.go (right): http://codereview.appspot.com/154179/diff/2001/1006#newcode646 src/pkg/http/request.go:646: if r.Form == nil { This cannot happen ...
14 years, 4 months ago (2009-11-17 21:02:28 UTC) #4
rsc
14 years, 4 months ago (2009-11-17 22:45:14 UTC) #5
*** Submitted as http://code.google.com/p/go/source/detail?r=751eaa8f96f7 ***

http: do not crash accessing r.Form if ParseForm fails

Fixes issue 233.

R=dsymonds1
http://codereview.appspot.com/154179
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b