Issue 154121: json: allow one to unmarshal a top-level JSON array.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 154121: json: allow one to unmarshal a top-level JSON array. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 5 months ago by agl1

Modified:
14 years, 5 months ago

Reviewers:
rsc

CC:
golang-dev

Visibility:
Public.

Description

json: allow one to unmarshal a top-level JSON array. Fixies issue 114.

Patch Set 2 : code review 154121: json: allow one to unmarshal a top-level JSON array. #

Patch Set 3 : code review 154121: json: allow one to unmarshal a top-level JSON array. #

Created: 14 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -2 lines)			Patch
	M	src/pkg/json/struct.go	View	1	2 chunks	+18 lines, -2 lines	0 comments	Download
	M	src/pkg/json/struct_test.go	View	1	1 chunk	+25 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

LGTM http://codereview.appspot.com/154121/diff/1/2 File src/pkg/json/struct.go (right): http://codereview.appspot.com/154121/diff/1/2#newcode282 src/pkg/json/struct.go:282: // In order to unmarshal a top-level JSON ...

14 years, 5 months ago (2009-11-13 20:54:40 UTC) #2

agl1

http://codereview.appspot.com/154121/diff/1/2 File src/pkg/json/struct.go (right): http://codereview.appspot.com/154121/diff/1/2#newcode282 src/pkg/json/struct.go:282: // In order to unmarshal a top-level JSON array, ...

14 years, 5 months ago (2009-11-13 21:00:22 UTC) #3

agl1

14 years, 5 months ago (2009-11-13 21:00:46 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=e88678b39a34 ***

json: allow one to unmarshal a top-level JSON array.

Fixies issue 114.

R=rsc
CC=golang-dev
http://codereview.appspot.com/154121

Expand All Messages | Collapse All Messages