Issue 154108: code review 154108: yet another attempt to avoid conflicts with

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 154108: code review 154108: yet another attempt to avoid conflicts with (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 5 months ago by rsc

Modified:
14 years, 5 months ago

Reviewers:
r

Visibility:
Public.

Description

yet another attempt to avoid conflicts with <stdio.h>, which we weren't even #including

Patch Set 1 #

Patch Set 2 : code review 154108: yet another attempt to avoid conflicts with #

Patch Set 3 : code review 154108: yet another attempt to avoid conflicts with #

Created: 14 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -10 lines)			Patch
M	src/cmd/5a/a.h	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	src/cmd/5a/a.y	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/6a/a.h	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	src/cmd/6a/a.y	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/8a/a.h	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	src/cmd/8a/a.y	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/cc/cc.h	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	src/cmd/cc/cc.y	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/gc/go.h	View	1 chunk	+5 lines, -3 lines	0 comments	Download
M	src/cmd/gc/go.y	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

14 years, 5 months ago (2009-11-13 07:38:50 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=1d9d926b1aa7 ***

yet another attempt to avoid conflicts with
<stdio.h>, which we weren't even #including

R=r
http://codereview.appspot.com/154108

Expand All Messages | Collapse All Messages