Issue 154102: code review 154102: Remove -align flag from gofmt.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 154102: code review 154102: Remove -align flag from gofmt. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 5 months ago by gri

Modified:
14 years, 5 months ago

Reviewers:
rsc

Visibility:
Public.

Description

Remove -align flag from gofmt. (Making it work correctly with -spaces is a bit of work and the output won't make much sense as it is intended as input to tabwriter.) Fixes issue 100.

Patch Set 1 #

Patch Set 2 : code review 154102: Remove -align flag from gofmt. #

Patch Set 3 : code review 154102: Remove -align flag from gofmt. #

Created: 14 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -6 lines)			Patch
	M	src/cmd/gofmt/doc.go	View		1 chunk	+0 lines, -2 lines	0 comments	Download
	M	src/cmd/gofmt/gofmt.go	View		2 chunks	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

14 years, 5 months ago (2009-11-13 02:26:47 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=976bf5096d9d ***

Remove -align flag from gofmt.
(Making it work correctly with -spaces is a bit of work and the output
won't make much sense as it is intended as input to tabwriter.)
Fixes issue 100.

R=rsc
http://codereview.appspot.com/154102

Expand All Messages | Collapse All Messages