Issue 154101: code review 154101: add support for pre arm v6 cas. set GOARM=5 to enable.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 154101: code review 154101: add support for pre arm v6 cas. set GOARM=5 to enable. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 5 months ago by kaib

Modified:
14 years, 5 months ago

Reviewers:
rsc

Visibility:
Public.

Description

add support for pre arm v6 cas. set GOARM=5 to enable.

Patch Set 2 : code review 154101: add support for pre arm v6 cas. set GOARM=5 to enable. #

Total comments: 2

Patch Set 3 : code review 154101: add support for pre arm v6 cas. set GOARM=5 to enable. #

Created: 14 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+45 lines, -0 lines)			Patch
M	src/pkg/runtime/Makefile	View	1 chunk	+3 lines, -1 line	0 comments	Download
A	src/pkg/runtime/arm/cas5.s	View	1 chunk	+43 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/arm/cas6.s	View	0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

LGTM http://codereview.appspot.com/154101/diff/1001/1002 File src/pkg/runtime/Makefile (right): http://codereview.appspot.com/154101/diff/1001/1002#newcode31 src/pkg/runtime/Makefile:31: GOARM ?= 6 drop spaces to match surrounding ...

14 years, 5 months ago (2009-11-12 23:21:57 UTC) #2

kaib

14 years, 5 months ago (2009-11-12 23:23:24 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=b55da7e4a1a5 ***

add support for pre arm v6 cas. set GOARM=5 to enable.

R=rsc
http://codereview.appspot.com/154101

Expand All Messages | Collapse All Messages