Created new Conn.Flush() public method so the fd pipeli...

Created new Conn.Flush() public method so the fd pipeline can be drained arbitrarily by the user.
Commented both flush methods so people know what they are looking at.

This is a necessary fix for streaming and long polling HTTP services.
Fixes issue 93.

[rsc, 2009-11-13 02:32:59]

Looks pretty good.  A few procedural things.

http://codereview.appspot.com/154099/diff/1/2
File CONTRIBUTORS (right):

http://codereview.appspot.com/154099/diff/1/2#newcode52
CONTRIBUTORS:52: David Titarenco <david@polyfx.com>
Please split this change into its own, separate CL.
There should be an accompanying change to AUTHORS,
as described in
  http://golang.org/doc/contribute.html#copyright
Please let us know which form you filled out.

Thanks.

http://codereview.appspot.com/154099/diff/1/3
File src/pkg/http/server.go (right):

http://codereview.appspot.com/154099/diff/1/3#newcode241
src/pkg/http/server.go:241: // Private flush !! Only used when closing
connections !!
Instead of this, why not rename the method:
finishRequest would be a clear name and wouldn't
need a comment.

http://codereview.appspot.com/154099/diff/1/3#newcode255
src/pkg/http/server.go:255: // Public Flush - HTTP streaming, comet, etc.
Doc comments should be complete sentences; see
http://golang.org/doc/effective_go.html#commentary

// Flush sends any buffered data to the client.

[david.titarenco, 2009-11-13 06:02:29]

Thanks for the support and help. Re-upped Patch set 2. I'll be filling out the
individual contributor license agreement and uploading the CONTRIBUTORS and
AUTHORS changes in a separate CL.

The "Contributing to the Go project" web page is a bit convoluted, I apologize
for my confusion!

[r, 2009-11-13 07:04:20]

http://codereview.appspot.com/154099/diff/1004/6
File CONTRIBUTORS (right):

http://codereview.appspot.com/154099/diff/1004/6#newcode52
CONTRIBUTORS:52: David Titarenco <david@polyfx.com>
please put this in a different change list

[david.titarenco, 2009-11-13 07:36:06]

Already did, I wasn't sure how to remove the CONTRIBUTORS file from this CL.

[rsc, 2009-11-13 07:47:51]

http://codereview.appspot.com/154099/diff/1004/7
File src/pkg/http/server.go (right):

http://codereview.appspot.com/154099/diff/1004/7#newcode241
src/pkg/http/server.go:241: func (c *Conn) terminateRequest() {
Please make this finishRequest.
Terminate suggests aborting to me, and it's not.

http://codereview.appspot.com/154099/diff/1004/7#newcode254
src/pkg/http/server.go:254: // Flush the TCP buffer, immediately draining it to
the client.
Documentation comments should be complete sentences,
as explained in http://golang.org/doc/effective_go.html#commentary.

// Flush sends any buffered data to the client.

(More concise, equally descriptive, does not hard-code
TCP, since you might run HTTP over other networks too.)

[david.titarenco, 2009-11-13 07:58:15]

http://codereview.appspot.com/154099/diff/1004/6
File CONTRIBUTORS (right):

http://codereview.appspot.com/154099/diff/1004/6#newcode52
CONTRIBUTORS:52: David Titarenco <david@polyfx.com>
On 2009/11/13 07:04:20, r wrote:
> please put this in a different change list

Done.

[david.titarenco, 2009-11-13 08:01:52]

Removed CONTRIBUTORS from this CL. Changed the comment to what you suggested.

[rsc, 2009-11-13 08:03:33]

http://codereview.appspot.com/154099/diff/1004/7
File src/pkg/http/server.go (right):

http://codereview.appspot.com/154099/diff/1004/7#newcode241
src/pkg/http/server.go:241: func (c *Conn) terminateRequest() {
On 2009/11/13 07:47:51, rsc wrote:
> Please make this finishRequest.
> Terminate suggests aborting to me, and it's not.

missed this?

[david.titarenco, 2009-11-13 08:13:10]

Yeah sorry about that, it's late. Fixed. 

You're right, close is more like the "terminate" of the struct. I just felt
finish was kind of superfluous. I'm still sifting through the docs -- there's a
lot of information to take in. Thank you for being so helpful :)

[rsc, 2009-11-13 08:36:23]

Sorry, one more nit.
I would make the change myself
but it will cause problems when you
sync if I submit something different.

http://codereview.appspot.com/154099/diff/15/1013
File src/pkg/http/server.go (right):

http://codereview.appspot.com/154099/diff/15/1013#newcode288
src/pkg/http/server.go:288: c.terminateRequest();
Looks like you missed a line?  
Please check that "make" runs and then re-upload.

[david.titarenco, 2009-11-13 08:42:41]

Yeah I definitely missed a line. Fixed. 

The make is really buggy on my system (I already commented on some similar
issues as well as submitted one of my own). It _appears_ that everything builds
but if I screw something up it only shows up when I try to import that specific
library (ie. hello.go:6: fatal error: can't find import: http).

[david.titarenco, 2009-11-13 09:29:30]

For simplicity's sake, I'd rather use david.titarenco@gmail.com, thanks for
updating the CL.

[rsc, 2009-11-14 02:06:48]

*** Submitted as http://code.google.com/p/go/source/detail?r=cd0140653802 ***

Created new Conn.Flush() public method so the fd pipeline can be drained
arbitrarily by the user.
Commented both flush methods so people know what they are looking at.

This is a necessary fix for streaming and long polling HTTP services.
Fixes issue 93.

R=r, rsc, david.titarenco
http://codereview.appspot.com/154099

Committer: Russ Cox <rsc@golang.org>