Issue 154071: code review 154071: Fix capitalisation of "Git".

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 154071: code review 154071: Fix capitalisation of "Git". (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 5 months ago by dsymonds

Modified:
15 years, 5 months ago

Reviewers:
rsc

Visibility:
Public.

Patch Set 2 : code review 154071: Fix capitalisation of "Git". #

Patch Set 3 : code review 154071: Fix capitalisation of "Git". #

Patch Set 4 : code review 154071: Fix capitalisation of "Git". #

Total comments: 2

Patch Set 5 : code review 154071: Fix capitalisation of "Git". #

Created: 15 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -20 lines)			Patch
M	src/cmd/hgpatch/doc.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/encoding/git85/git.go	View	3	4 chunks	+5 lines, -5 lines	0 comments	Download
M	src/pkg/patch/git.go	View	3	3 chunks	+10 lines, -10 lines	0 comments	Download
M	src/pkg/patch/patch.go	View	3 4	4 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

dsymonds

Hello rsc, I'd like you to review the following change.

15 years, 5 months ago (2009-11-12 00:13:15 UTC) #1

dsymonds

Hello rsc, I'd like you to review the following change.

15 years, 5 months ago (2009-11-12 00:14:12 UTC) #2

rsc

Take a look at the diffs after 'hg upload' and make sure it's just the ...

15 years, 5 months ago (2009-11-12 00:19:01 UTC) #3

rsc

Still one change. http://codereview.appspot.com/154071/diff/19/23 File src/pkg/patch/patch.go (right): http://codereview.appspot.com/154071/diff/19/23#newcode125 src/pkg/patch/patch.go:125: // rename from %s - file ...

15 years, 5 months ago (2009-11-12 00:36:15 UTC) #4

dsymonds

http://codereview.appspot.com/154071/diff/19/23 File src/pkg/patch/patch.go (right): http://codereview.appspot.com/154071/diff/19/23#newcode125 src/pkg/patch/patch.go:125: // rename from %s - file renamed from other ...

15 years, 5 months ago (2009-11-12 00:45:04 UTC) #5

rsc

15 years, 5 months ago (2009-11-12 01:31:29 UTC) #6

*** Submitted as http://code.google.com/p/go/source/detail?r=7dce62a64900 ***

Fix capitalisation of "Git".

R=rsc
http://codereview.appspot.com/154071

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages