Issue 154065: roll back 3985: build is broken

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 154065: roll back 3985: build is broken (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 1 month ago by rsc

Modified:
16 years, 1 month ago

Reviewers:
agl1

CC:
golang-dev

Visibility:
Public.

Description

roll back 3985: build is broken

Patch Set 1 #

Patch Set 2 : code review 154065: roll back 3985: build is broken #

Created: 16 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+162 lines, -563 lines)			Patch
M	src/pkg/Make.deps	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	src/pkg/big/int.go	View		5 chunks	+83 lines, -24 lines	0 comments	Download
M	src/pkg/big/int_test.go	View		11 chunks	+12 lines, -101 lines	0 comments	Download
M	src/pkg/big/nat.go	View	1	10 chunks	+11 lines, -300 lines	0 comments	Download
M	src/pkg/big/nat_test.go	View		2 chunks	+1 line, -95 lines	0 comments	Download
M	src/pkg/bignum/bignum.go	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	src/pkg/crypto/rsa/rsa.go	View	1	13 chunks	+37 lines, -27 lines	0 comments	Download
M	src/pkg/crypto/rsa/rsa_test.go	View		1 chunk	+14 lines, -8 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

rsc

16 years, 1 month ago (2009-11-11 20:54:54 UTC) #1

*** Submitted as http://code.google.com/p/go/source/detail?r=f7fa2bef8c13 ***

roll back 3985: build is broken

TBR=agl1
CC=golang-dev
http://codereview.appspot.com/154065

Expand All Messages | Collapse All Messages