Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(69)

Issue 154063: Some core changes required for the tools service (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 7 months ago by MikeSamuel
Modified:
16 years, 7 months ago
Reviewers:
Jasvir
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Fixed bug: myvn filetypes marks gifs as svn:mime-type=text/gif Added a minimizing CSS printer. This is svn cped from CssPrettyPrinter. Got rid of some unnecessary parenthesization around unary operators. We now render !!x as !!x instead of !(!x) Updated version of google-code-prettify, and turned the second version under doc/html into symlinks into third_party. Allow constant folding to NaN which is rendered by RealLiteral as (0/0). Fixed rendering of -0 to preserve sign. Fixed some message strings that were confusing. Added an immutable map constructor to Maps. Previously we often wrote private static final Map<Foo, Bar> LOOKUP_TABLE; static { LOOKUP_TABLE = /* an empty mutable map */; LOOKUP_TABLE.put(...); // many more puts. } Now you can write private static final Map<Foo, Bar> LOOKUP_TABLE = Maps.<Foo, Bar>immutableMap() .put(a, b) .put(c, d) .create(); So the result is immutable, and no need for static inializers or temporary variables. Added jakarta file upload jars and dependency to third_party. Removed useless <permissions> from build.xml. This was cruft from the Rhino sandboxing CL. It doesn't work in forked mode, and so we modified the sandbox to never allow file access, and instead resolve file: URLs using the class loader. Submitted @3854

Patch Set 1 #

Patch Set 2 : Some core changes required for the tools service #

Patch Set 3 : Some core changes required for the tools service #

Patch Set 4 : Some core changes required for the tools service #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+778 lines, -467 lines) Patch
M build.xml View 1 2 3 7 chunks +19 lines, -18 lines 0 comments Download
A doc/html/common/lang-css.js View 1 chunk +1 line, -0 lines 0 comments Download
MM doc/html/common/prettify.css View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
MM doc/html/common/prettify.js View 1 2 3 1 chunk +1 line, -25 lines 0 comments Download
M src/com/google/caja/ancillary/linter/Linter.java View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M src/com/google/caja/parser/js/NumberLiteral.java View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/com/google/caja/parser/js/Operation.java View 1 2 3 3 chunks +4 lines, -5 lines 2 comments Download
M src/com/google/caja/parser/js/RealLiteral.java View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
A + src/com/google/caja/render/CssMinimalPrinter.java View 3 chunks +10 lines, -77 lines 0 comments Download
M src/com/google/caja/render/CssPrettyPrinter.java View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/com/google/caja/reporting/MessageType.java View 1 2 3 2 chunks +2 lines, -3 lines 0 comments Download
M src/com/google/caja/util/Maps.java View 1 2 3 2 chunks +32 lines, -0 lines 0 comments Download
M src/com/google/caja/util/Sets.java View 1 2 3 2 chunks +19 lines, -1 line 0 comments Download
M tests/com/google/caja/ancillary/linter/LinterTest.java View 2 3 4 chunks +4 lines, -4 lines 0 comments Download
M tests/com/google/caja/lexer/CssLexerTest.java View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M tests/com/google/caja/parser/js/ExpressionTest.java View 1 2 3 3 chunks +4 lines, -2 lines 0 comments Download
M tests/com/google/caja/parser/js/rendergolden4.txt View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M tests/com/google/caja/parser/js/rendergolden6.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + tests/com/google/caja/render/CssMinimalPrinterTest.java View 1 chunk +8 lines, -4 lines 0 comments Download
A third_party/java/jakarta_commons/LICENSE.txt View 1 chunk +202 lines, -0 lines 0 comments Download
A third_party/java/jakarta_commons/NOTICE.txt View 1 chunk +5 lines, -0 lines 0 comments Download
A third_party/java/jakarta_commons/commons-fileupload-1.2.1.jar View Binary file 0 comments Download
A third_party/java/jakarta_commons/commons-fileupload-1.2.1-sources.jar View Binary file 0 comments Download
A third_party/java/jakarta_commons/commons-io-1.4.jar View Binary file 0 comments Download
A third_party/java/jakarta_commons/commons-io-1.4-sources.jar View Binary file 0 comments Download
M third_party/js/prettify/lang-css.js View 1 2 3 2 chunks +15 lines, -2 lines 0 comments Download
M third_party/js/prettify/prettify.js View 1 2 3 30 chunks +437 lines, -316 lines 0 comments Download
M tools/myvn View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
MikeSamuel
16 years, 7 months ago (2009-11-11 19:56:09 UTC) #1
MikeSamuel
ping
16 years, 7 months ago (2009-11-17 21:54:58 UTC) #2
Jasvir
LGTM http://codereview.appspot.com/154063/diff/4001/4014 File src/com/google/caja/parser/js/Operation.java (right): http://codereview.appspot.com/154063/diff/4001/4014#newcode398 src/com/google/caja/parser/js/Operation.java:398: if (op.getType() == OperatorType.PREFIX) { return false; } ...
16 years, 7 months ago (2009-11-18 23:56:00 UTC) #3
MikeSamuel
16 years, 7 months ago (2009-11-19 00:37:09 UTC) #4
http://codereview.appspot.com/154063/diff/4001/4014
File src/com/google/caja/parser/js/Operation.java (right):

http://codereview.appspot.com/154063/diff/4001/4014#newcode398
src/com/google/caja/parser/js/Operation.java:398: if (op.getType() ==
OperatorType.PREFIX) { return false; }
On 2009/11/18 23:56:00, jasvir wrote:
> Appears to directly contradict comment on Line 394.  In any case should be
> before the above comment.

Fixed comment and moved line above.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b