Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(28)

Issue 154056: Issue #768: Chord repetition shortcut (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 8 months ago by nicolas.sceaux
Modified:
8 years, 3 months ago
Reviewers:
carl.d.sorensen
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Issue #768: Chord repetition shortcut In the lexer, add a chord repetition state, holding the repetition symbol (like note names, but for chord repetition), the repetition function used to copy the previous chord, and a slot to save the previous chord. Use the repetition symbol to detect a chord repetition when lexing. In the parser, when a note chord is found, save it (it becomes previous chord). When a chord repetition token is found, make a chord using the repetition function and the previous chord. The repetition symbol and function are initialized in ly/chord-repetition-init.ly. The repetition symbol defaults to `q' (as quote or qord -- as suggested by Werner). The function copies the pitches, but not articulations.

Patch Set 1 #

Total comments: 3

Patch Set 2 : Doc fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -5 lines) Patch
M Documentation/notation/simultaneous.itely View 1 3 chunks +25 lines, -1 line 0 comments Download
A input/regression/chord-repetition.ly View 1 chunk +12 lines, -0 lines 0 comments Download
M input/regression/quote-kill-cues.ly View 1 chunk +3 lines, -3 lines 0 comments Download
M lily/include/lily-lexer.hh View 2 chunks +16 lines, -0 lines 0 comments Download
M lily/lexer.ll View 1 chunk +3 lines, -0 lines 0 comments Download
M lily/lily-lexer.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M lily/lily-parser-scheme.cc View 1 chunk +26 lines, -0 lines 0 comments Download
M lily/parser.yy View 3 chunks +12 lines, -1 line 0 comments Download
A ly/chord-repetition-init.ly View 1 chunk +19 lines, -0 lines 0 comments Download
M ly/declarations-init.ly View 1 chunk +2 lines, -0 lines 0 comments Download
scm/ly-syntax-constructors.scm View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4
nicolas.sceaux
Hi, Here is a patch adding the chord repetition functionality that has been discussed a ...
9 years, 8 months ago (2009-11-11 19:12:55 UTC) #1
Carl
Nicolas, It looks great! Thanks. I have just a couple of suggestions for changes to ...
9 years, 8 months ago (2009-11-12 21:40:37 UTC) #2
nicolas.sceaux
On 2009/11/12 21:40:37, Carl wrote: > http://codereview.appspot.com/154056/diff/1/10#newcode1 > ly/chord-repetition-init.ly:1: \version "2.13.8" > Just a question. ...
9 years, 8 months ago (2009-11-13 17:43:17 UTC) #3
nicolas.sceaux
9 years, 8 months ago (2009-11-14 10:30:37 UTC) #4
On 2009/11/12 21:40:37, Carl wrote:
> Nicolas,
> 
> It looks great!  Thanks.
> 
> I have just a couple of suggestions for changes to the documentation

I've addressed your remarks concerning documentation in a new patch

  <http://codereview.appspot.com/154056>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b