Expand and refactor window.onerror support.

Guest window.onerror is now invoked for these error cases:
* top-level code (that is, <script>throw ...;</script>). Fixes
  https://code.google.com/p/google-caja/issues/detail?id=1433.
* setTimeout, setInterval, or requestAnimationFrame callbacks.

The existing calls to onerror have been changed to use a single
implementation, domicile.handleUncaughtException. This function
takes care to not throw even if the error object or onerror handler
cause errors when used, and passes the full set of standardized
arguments (still with dummy values).

Also reorganized the setTimeout-and-friends implementation
(tameSetAndClear) so that the early-exit path is more direct.

@r5701

[felix8a, 2014-10-12 20:04:50]

lgtm except below

https://codereview.appspot.com/153290043/diff/1/src/com/google/caja/plugin/do...
File src/com/google/caja/plugin/domado.js (right):

https://codereview.appspot.com/153290043/diff/1/src/com/google/caja/plugin/do...
src/com/google/caja/plugin/domado.js:6760: if (typeof console !== 'undefined') {
maybe hoist this if outside the try?

https://codereview.appspot.com/153290043/diff/1/tests/com/google/caja/plugin/...
File tests/com/google/caja/plugin/test-cajajs-invocation.js (right):

https://codereview.appspot.com/153290043/diff/1/tests/com/google/caja/plugin/...
tests/com/google/caja/plugin/test-cajajs-invocation.js:96:
caja.load(createDiv(), uriPolicy, jsunitCallback(function(frame) {
space after function

https://codereview.appspot.com/153290043/diff/1/tests/com/google/caja/plugin/...
tests/com/google/caja/plugin/test-cajajs-invocation.js:115:
.run(jsunitCallback(function(result) {
space after function

https://codereview.appspot.com/153290043/diff/1/tests/com/google/caja/plugin/...
tests/com/google/caja/plugin/test-cajajs-invocation.js:556:
jsunitRun('testScriptError');
arg should be deleted, right? debugging leftover?
jsunitRun seems to me to do the wrong thing with opt_testnames anyway.

https://codereview.appspot.com/153290043/diff/1/tests/com/google/caja/plugin/...
File tests/com/google/caja/plugin/test-domado-events-guest.html (right):

https://codereview.appspot.com/153290043/diff/1/tests/com/google/caja/plugin/...
tests/com/google/caja/plugin/test-domado-events-guest.html:42: window.onerror =
(function (savedOnerror) {
this capitalization of savedOnerror feels wrong to me but all the alternatives
feel more wrong, heh

https://codereview.appspot.com/153290043/diff/1/tests/com/google/caja/plugin/...
tests/com/google/caja/plugin/test-domado-events-guest.html:454: <p
class="testcontainer" id="testTimeoutError">
this is an async test, add 'waiting' to the class

https://codereview.appspot.com/153290043/diff/1/tests/com/google/caja/plugin/...
tests/com/google/caja/plugin/test-domado-events-guest.html:458:
jsunitRegister('testTimeoutError', function() {
space after function for consistency, and below

[kpreid_google, 2014-10-13 16:56:03]

Guest window.onerror is now invoked for these error cases:
* top-level code (that is, <script>throw ...;</script>). Fixes
  https://code.google.com/p/google-caja/issues/detail?id=1433.
* setTimeout, setInterval, or requestAnimationFrame callbacks.

The existing calls to onerror have been changed to use a single
implementation, domicile.handleUncaughtException. This function
takes care to not throw even if the error object or onerror handler
cause errors when used, and passes the full set of standardized
arguments (still with dummy values).

Also reorganized the setTimeout-and-friends implementation
(tameSetAndClear) so that the early-exit path is more direct.

[kpreid_google, 2014-10-13 16:58:00]

https://codereview.appspot.com/153290043/diff/1/src/com/google/caja/plugin/do...
File src/com/google/caja/plugin/domado.js (right):

https://codereview.appspot.com/153290043/diff/1/src/com/google/caja/plugin/do...
src/com/google/caja/plugin/domado.js:6760: if (typeof console !== 'undefined') {
On 2014/10/12 20:04:50, felix8a wrote:
> maybe hoist this if outside the try?

Done.

https://codereview.appspot.com/153290043/diff/1/tests/com/google/caja/plugin/...
File tests/com/google/caja/plugin/test-cajajs-invocation.js (right):

https://codereview.appspot.com/153290043/diff/1/tests/com/google/caja/plugin/...
tests/com/google/caja/plugin/test-cajajs-invocation.js:96:
caja.load(createDiv(), uriPolicy, jsunitCallback(function(frame) {
On 2014/10/12 20:04:50, felix8a wrote:
> space after function

I can't find a citation but my understanding of the style we're supposed to be
following (but historically have been mixed up about) is that there should be no
space there. I've been converting code to the no-space style as I touch it.

https://codereview.appspot.com/153290043/diff/1/tests/com/google/caja/plugin/...
tests/com/google/caja/plugin/test-cajajs-invocation.js:556:
jsunitRun('testScriptError');
On 2014/10/12 20:04:50, felix8a wrote:
> arg should be deleted, right? debugging leftover?

Done.

> jsunitRun seems to me to do the wrong thing with opt_testnames anyway.

Hm, yes, it's trying to do varargs but also have a second parameter, and is a
bit sloppy otherwise. Added a comment to note the problem — not a priority since
it only affects debugging stuff.

https://codereview.appspot.com/153290043/diff/1/tests/com/google/caja/plugin/...
File tests/com/google/caja/plugin/test-domado-events-guest.html (right):

https://codereview.appspot.com/153290043/diff/1/tests/com/google/caja/plugin/...
tests/com/google/caja/plugin/test-domado-events-guest.html:42: window.onerror =
(function (savedOnerror) {
On 2014/10/12 20:04:50, felix8a wrote:
> this capitalization of savedOnerror feels wrong to me but all the alternatives
> feel more wrong, heh

Exactly.

https://codereview.appspot.com/153290043/diff/1/tests/com/google/caja/plugin/...
tests/com/google/caja/plugin/test-domado-events-guest.html:454: <p
class="testcontainer" id="testTimeoutError">
On 2014/10/12 20:04:50, felix8a wrote:
> this is an async test, add 'waiting' to the class

My understanding was that 'waiting' was obsolete. Your TODO comment at
BrowserTestCase.java claims this. Clarify?

[felix8a, 2014-10-13 17:49:22]

lgtm

https://codereview.appspot.com/153290043/diff/1/tests/com/google/caja/plugin/...
File tests/com/google/caja/plugin/test-cajajs-invocation.js (right):

https://codereview.appspot.com/153290043/diff/1/tests/com/google/caja/plugin/...
tests/com/google/caja/plugin/test-cajajs-invocation.js:96:
caja.load(createDiv(), uriPolicy, jsunitCallback(function(frame) {
On 2014/10/13 16:58:00, kpreid_google wrote:
> On 2014/10/12 20:04:50, felix8a wrote:
> > space after function
> 
> I can't find a citation but my understanding of the style we're supposed to be
> following (but historically have been mixed up about) is that there should be
no
> space there. I've been converting code to the no-space style as I touch it.

personally, I prefer to remain consistent within a file, and change style of an
entire file all at once, but ok.

https://codereview.appspot.com/153290043/diff/1/tests/com/google/caja/plugin/...
File tests/com/google/caja/plugin/test-domado-events-guest.html (right):

https://codereview.appspot.com/153290043/diff/1/tests/com/google/caja/plugin/...
tests/com/google/caja/plugin/test-domado-events-guest.html:454: <p
class="testcontainer" id="testTimeoutError">
On 2014/10/13 16:58:00, kpreid_google wrote:
> On 2014/10/12 20:04:50, felix8a wrote:
> > this is an async test, add 'waiting' to the class
> 
> My understanding was that 'waiting' was obsolete. Your TODO comment at
> BrowserTestCase.java claims this. Clarify?

ah, right, I forgot about that. ok.