Issue 1532041: code review 1532041: draw.Draw fast paths for the Over operator.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1532041: code review 1532041: draw.Draw fast paths for the Over operator. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 9 months ago by nigeltao

Modified:
14 years, 9 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

draw.Draw fast paths for the Over operator. Time (us) to draw a 200x200 src onto an image.RGBA dst with the Over operator. Each case was measured three separate times, and the sorted times are reported. Fill case (where src is an image.ColorImage): Before: 7438, 7511, 7526 After: 3073, 3087, 3102 Copy case (where src is an image.RGBA): Before: 9506, 9510, 9563 After: 5262, 5300, 5344

Patch Set 1 #

Patch Set 2 : code review 1532041: draw.Draw fast paths for the Over operator. #

Patch Set 3 : code review 1532041: draw.Draw fast paths for the Over operator. #

Created: 14 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+93 lines, -34 lines)			Patch
	M	src/pkg/exp/draw/draw.go	View		11 chunks	+93 lines, -34 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

nigeltao

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 9 months ago (2010-06-04 00:05:19 UTC) #1

nigeltao

14 years, 9 months ago (2010-06-04 00:19:11 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=e712aba3277f ***

draw.Draw fast paths for the Over operator.

Time (us) to draw a 200x200 src onto an image.RGBA dst with the Over
operator. Each case was measured three separate times, and the sorted
times are reported.

Fill case (where src is an image.ColorImage):
Before:
7438, 7511, 7526
After:
3073, 3087, 3102

Copy case (where src is an image.RGBA):
Before:
9506, 9510, 9563
After:
5262, 5300, 5344

R=rsc
CC=golang-dev
http://codereview.appspot.com/1532041

Expand All Messages | Collapse All Messages