Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1465)

Issue 152077: code review 152077: two gopack nits. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 5 months ago by rsc
Modified:
14 years, 5 months ago
Reviewers:
r
Visibility:
Public.

Description

two gopack nits. 1. allocate an extra byte for use by write. 2. throw away the code trying to translate uid and gid to names. i suspect it of causing seg faults in some situations, and it is not needed by the compilers. Fixes issue 48. (I hope.)

Patch Set 1 #

Patch Set 2 : code review 152077: two gopack nits. #

Patch Set 3 : code review 152077: two gopack nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -13 lines) Patch
M src/cmd/gopack/ar.c View 1 chunk +4 lines, -0 lines 0 comments Download
M src/lib9/_p9dir.c View 3 chunks +0 lines, -13 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello r, I'd like you to review the following change.
14 years, 5 months ago (2009-11-11 21:59:20 UTC) #1
r
LGTM
14 years, 5 months ago (2009-11-11 22:12:48 UTC) #2
rsc
14 years, 5 months ago (2009-11-11 22:48:36 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=4e77bae1405c ***

two gopack nits.

1. allocate an extra byte for use by write.
2. throw away the code trying to translate
   uid and gid to names.  i suspect it of causing
   seg faults in some situations, and it is
   not needed by the compilers.

Fixes issue 48.  (I hope.)

R=r
http://codereview.appspot.com/152077
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b