Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2)

Issue 152058: add WIFI_PHY_STANDARD_80211p_CCH and SCH

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by nowatkom
Modified:
11 years, 3 months ago
Reviewers:
Mathieu Lacage
CC:
ns-3-reviews_googlegroups.com
Visibility:
Public.

Patch Set 1 #

Total comments: 2

Patch Set 2 : add WIFI_PHY_STANDARD_80211p_CCH and SCH #

Patch Set 3 : add WIFI_PHY_STANDARD_80211p_CCH and SCH #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -2 lines) Patch
M src/devices/wifi/qap-wifi-mac.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M src/devices/wifi/qsta-wifi-mac.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M src/devices/wifi/yans-wifi-phy.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2
Mathieu Lacage
The patchs looks good modulo my minor comments/questions below. Once you have resolved these, I ...
11 years, 3 months ago (2009-11-17 12:05:35 UTC) #1
nowatkom
11 years, 3 months ago (2009-11-18 03:20:17 UTC) #2
I added the changes to qap-wifi-mac.cc and qsta-wifi-mac.cc (see Patch Set 2).

802.11p is specifically set to work on channels 172-184 (center freq of 5.860
GHz for channel 172).  I would recommend leaving the starting frequency at 5.0
GHz.  Yes, the comment was a copy/paste from the the 10MHz code.  Should I
remove the comment?

Thanks!
  Michael

On 2009/11/17 12:05:35, Mathieu Lacage wrote:
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b