Issue 152045: Fixing static injections

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 152045: Fixing static injections (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 5 months ago by Aragos

Modified:
16 years, 3 months ago

Reviewers:
Brian_Stoler, lord_damokles, nwolf

Base URL:
http://google-gin.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Added proper dependency registration for static injections.

Patch Set 2 : Fixed error handling #

Created: 16 years, 3 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -8 lines)			Patch
src/com/google/gwt/inject/rebind/BindingsProcessor.java	View	1	8 chunks	+51 lines, -7 lines	0 comments	Download
src/com/google/gwt/inject/rebind/GinjectorOutputter.java	View	1	1 chunk	+1 line, -1 line	0 comments	Download
test/com/google/gwt/inject/client/misc/StaticClass.java	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download
test/com/google/gwt/inject/client/misc/StaticInjectTest.java	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

nwolf

LGTM http://codereview.appspot.com/152045/diff/1/5 File src/com/google/gwt/inject/rebind/BindingsProcessor.java (right): http://codereview.appspot.com/152045/diff/1/5#newcode743 src/com/google/gwt/inject/rebind/BindingsProcessor.java:743: RequiredKeys keys = keyUtil.getRequiredKeys(method); couldn't method potentially be ...

16 years, 3 months ago (2009-12-29 18:22:23 UTC) #1

Aragos

16 years, 3 months ago (2009-12-29 18:52:33 UTC) #2

http://codereview.appspot.com/152045/diff/1/5
File src/com/google/gwt/inject/rebind/BindingsProcessor.java (right):

http://codereview.appspot.com/152045/diff/1/5#newcode743
src/com/google/gwt/inject/rebind/BindingsProcessor.java:743: RequiredKeys keys =
keyUtil.getRequiredKeys(method);
On 2009/12/29 18:22:23, nwolf wrote:
> couldn't method potentially be null at line 743?  Should the catch throw some
> sort of real exception? and if you're snoozing the error what does that really
> mean?

Thanks for catching this! Moved the method to the inner class where its used and
fixed error recording logic.

http://codereview.appspot.com/152045/diff/1/3
File test/com/google/gwt/inject/client/misc/StaticClass.java (right):

http://codereview.appspot.com/152045/diff/1/3#newcode59
test/com/google/gwt/inject/client/misc/StaticClass.java:59: public static
StaticInjectGinjector getInjector() {
On 2009/12/29 18:22:23, nwolf wrote:
> nit pick, order of methods seems off.

Done.

Expand All Messages | Collapse All Messages