Issue 1518041: org.apache.shindig.gadgets.parse.DefaultHtmlSerializer#serialize drops trailing comments

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1518041: org.apache.shindig.gadgets.parse.DefaultHtmlSerializer#serialize drops trailing comments (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 10 months ago by janluehe

Modified:
15 years, 9 months ago

Reviewers:
Paul Lindner, shindig.remailer

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/

Visibility:
Public.

Description

This fixes https://issues.apache.org/jira/browse/SHINDIG-1354

Patch Set 1 #

Created: 15 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
		java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/DefaultHtmlSerializer.java	View		1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Paul Lindner

Is there a test case? I started working on one with this patch but was ...

15 years, 9 months ago (2010-06-29 17:48:38 UTC) #2

janluehe

15 years, 9 months ago (2010-06-29 19:59:55 UTC) #3

Thanks for looking into this, Paul.

Below is a very simple test case.

To compile:
% javac -classpath shindig-gadgets.jar Test.java

To run:
% java -classpath
google-collections-1.0.jar:guice-2.0.jar:nekohtml-1.9.13.jar:shindig-gadgets.jar:.
Test

Without my fix, the output will be: "<ABC></ABC>"
With my fix, the output will be: "<ABC></ABC><!--XYZ-->"

import javax.xml.parsers.*;
import org.w3c.dom.*;
import org.apache.shindig.gadgets.parse.*;

public class Test {

  public static void main(String[] args) throws Exception {
    Document doc =
DocumentBuilderFactory.newInstance().newDocumentBuilder().newDocument();
    doc.appendChild(doc.createElement("ABC"));
    doc.appendChild(doc.createComment("XYZ"));

    DefaultHtmlSerializer serializer = new DefaultHtmlSerializer();
    System.out.println(serializer.serialize(doc));
  }
}


On 2010/06/29 17:48:38, Paul Lindner wrote:
> Is there a test case?   I started working on one with this patch but was
unable
> to get it working..

Expand All Messages | Collapse All Messages