code review 1514041: Remove last references to pchw, added gettime dummy fun...

Remove last references to pchw, added gettime dummy function to tiny to compile

[kardia, 2010-06-03 15:12:58]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[rsc1, 2010-06-03 17:01:53]

Looks pretty good, thanks.

Could you please complete the CLA as described at
http://golang.org/doc/contribute.html#copyright ?

Thanks.

> -extern void ·write(int32 fd, void *v, int32 len, int32 cap);   // slice,
> spelled out
> +extern void ·write(int fd, void *v, int len, int cap); // slice, spelled
> out

Instead of these changes the file should

#include "runtime.h"

We never use int in the runtime sources.

Russ

[kardia, 2010-06-03 18:47:29]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

Please take another look.

[kardia, 2010-06-03 18:49:12]

On 2010/06/03 18:47:29, kardia wrote:
> Hello mailto:golang-dev@googlegroups.com (cc:
mailto:golang-dev@googlegroups.com),
> 
> Please take another look.

Also completed CLA.

[rsc1, 2010-06-03 22:59:01]

looks good. a few more tiny edits
thanks.

http://codereview.appspot.com/1514041/diff/6001/7004
File src/pkg/runtime/tiny/386/signal.c (right):

http://codereview.appspot.com/1514041/diff/6001/7004#newcode1
src/pkg/runtime/tiny/386/signal.c:1: // just the write function
add a standard copyright header here, please.


// Copyright 2010 The Go Authors.  All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.

http://codereview.appspot.com/1514041/diff/6001/7004#newcode15
src/pkg/runtime/tiny/386/signal.c:15: gettime(int32 *a, int32 *b) {
brace on next line; sorry there's no cfmt. 
return is redundant.
also need to silence the compiler warnings
about unused a and b.

void
gettime(int32*, int32*)
{
}

will do.

[kardia, 2010-06-03 23:32:02]

Hello rsc (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc1, 2010-06-03 23:51:41]

LGTM

[rsc, 2010-06-07 21:18:46]

*** Submitted as http://code.google.com/p/go/source/detail?r=eba1d7b70ca0 ***

runtime: finish pchw -> tiny, added gettime for tiny

R=rsc
CC=golang-dev
http://codereview.appspot.com/1514041

Committer: Russ Cox <rsc@golang.org>