Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1)

Issue 151065: fix bug introduced by window.onload change (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 7 months ago by felix8a
Modified:
16 years, 7 months ago
Reviewers:
MikeSamuel
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

window.onload commit causes an error if window.onload is not set. oops. added a todo for testing that case, because it requires having more than one domita test, which is dependent on resolution of splitting up domita_test

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M src/com/google/caja/plugin/domita.js View 1 chunk +4 lines, -3 lines 0 comments Download
M tests/com/google/caja/plugin/domita_test_untrusted.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3
felix8a
16 years, 7 months ago (2009-11-10 03:05:24 UTC) #1
MikeSamuel
Sorry I didn't catch that in review. LGTM
16 years, 7 months ago (2009-11-10 03:37:41 UTC) #2
felix8a
16 years, 7 months ago (2009-11-10 03:40:37 UTC) #3
@r3836
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b