Fix 1153: add cellIndex, tbody.insertRow and deleteRow

Fix 1153: add cellIndex, tbody.insertRow and deleteRow

[MikeSamuel, 2009-11-06 22:26:20]

http://codereview.appspot.com/151049/diff/1/2
File tests/com/google/caja/plugin/domita_test_untrusted.html (right):

http://codereview.appspot.com/151049/diff/1/2#newcode3005
tests/com/google/caja/plugin/domita_test_untrusted.html:3005: try{
need space after keyword.

http://codereview.appspot.com/151049/diff/1/2#newcode3007
tests/com/google/caja/plugin/domita_test_untrusted.html:3007: } catch(e) {
and here and elsewhere

http://codereview.appspot.com/151049/diff/1/2#newcode3009
tests/com/google/caja/plugin/domita_test_untrusted.html:3009: }
Should this pass if an exception is not thrown?

[metaweta, 2009-11-06 22:33:37]

On 2009/11/06 22:26:20, MikeSamuel wrote:
> http://codereview.appspot.com/151049/diff/1/2
> File tests/com/google/caja/plugin/domita_test_untrusted.html (right):
> 
> http://codereview.appspot.com/151049/diff/1/2#newcode3005
> tests/com/google/caja/plugin/domita_test_untrusted.html:3005: try{
> need space after keyword.

Done

> http://codereview.appspot.com/151049/diff/1/2#newcode3007
> tests/com/google/caja/plugin/domita_test_untrusted.html:3007: } catch(e) {
> and here and elsewhere

Done

> http://codereview.appspot.com/151049/diff/1/2#newcode3009
> tests/com/google/caja/plugin/domita_test_untrusted.html:3009: }
> Should this pass if an exception is not thrown?

No, good catch.  Fixed.

[MikeSamuel, 2009-11-11 03:18:59]

LGTM

http://codereview.appspot.com/151049/diff/8/9
File tests/com/google/caja/plugin/domita_test_untrusted.html (right):

http://codereview.appspot.com/151049/diff/8/9#newcode3018
tests/com/google/caja/plugin/domita_test_untrusted.html:3018: if (tableDeleteRow
&& tbodyDeleteRow) {
Maybe assert that these two are true.

[metaweta, 2009-11-11 18:44:46]

On 2009/11/11 03:18:59, MikeSamuel wrote:
> LGTM
> 
> http://codereview.appspot.com/151049/diff/8/9
> File tests/com/google/caja/plugin/domita_test_untrusted.html (right):
> 
> http://codereview.appspot.com/151049/diff/8/9#newcode3018
> tests/com/google/caja/plugin/domita_test_untrusted.html:3018: if
(tableDeleteRow
> && tbodyDeleteRow) {
> Maybe assert that these two are true.

Fixed.

[MikeSamuel, 2009-11-11 19:58:10]

http://codereview.appspot.com/151049/diff/8/9
File tests/com/google/caja/plugin/domita_test_untrusted.html (right):

http://codereview.appspot.com/151049/diff/8/9#newcode3018
tests/com/google/caja/plugin/domita_test_untrusted.html:3018: if (tableDeleteRow
&& tbodyDeleteRow) {
On 2009/11/11 03:18:59, MikeSamuel wrote:
> Maybe assert that these two are true.

I was thinking more along the lines of
assertTrue(tableDeleteRow);
assertTrue(tbodyDeleteRow);