Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(19)

Issue 150070: support window.onload (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 7 months ago by felix8a
Modified:
16 years, 7 months ago
Reviewers:
MikeSamuel
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Domita supports window.addEventListener('load') but doesn't do anything with window.onload. This adds support for window.onload. It's not exactly identical to browser handling of window.onload, because the order of running onload handlers is different. Browsers act as if setting window.onload were a call to removeEventListener then addEventListener, and all the onload handlers get run in the order they were registered. I didn't see a reason to add all the code necessary to duplicate that order.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
M src/com/google/caja/plugin/domita.js View 2 chunks +10 lines, -1 line 0 comments Download
M tests/com/google/caja/plugin/domita_test_untrusted.html View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 3
felix8a
16 years, 7 months ago (2009-11-10 01:41:30 UTC) #1
MikeSamuel
LGTM
16 years, 7 months ago (2009-11-10 02:09:33 UTC) #2
felix8a
16 years, 7 months ago (2009-11-10 02:29:07 UTC) #3
@r3835
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b