Issue 150042: Fix for issue1280 in released series

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 150042: Fix for issue1280 in released series (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 6 months ago by ced1

Modified:
16 years, 6 months ago

Reviewers:
bch, yangoon1

Visibility:
Public.

Patch Set 2 : Modify read of action instead of changing search domain #

Created: 16 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -0 lines)			Patch
	M	invoice.py	View	1	1 chunk	+59 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bch

http://codereview.appspot.com/150042/diff/1/2 File invoice.py (right): http://codereview.appspot.com/150042/diff/1/2#newcode966 invoice.py:966: Seems good, the only problem that I can see ...

16 years, 6 months ago (2009-11-06 09:47:24 UTC) #1

ced1

http://codereview.appspot.com/150042/diff/1/2 File invoice.py (right): http://codereview.appspot.com/150042/diff/1/2#newcode966 invoice.py:966: On 2009/11/06 09:47:25, bch wrote: > Seems good, the ...

16 years, 6 months ago (2009-11-06 09:54:57 UTC) #2

yangoon1

I don't feel comfortable to solve the problem this way! http://codereview.appspot.com/150042/diff/1/2 File invoice.py (right): http://codereview.appspot.com/150042/diff/1/2#newcode951 ...

16 years, 6 months ago (2009-11-06 12:50:25 UTC) #3

bch

16 years, 6 months ago (2009-11-06 13:43:24 UTC) #4

http://codereview.appspot.com/150042/diff/1/2
File invoice.py (right):

http://codereview.appspot.com/150042/diff/1/2#newcode951
invoice.py:951: #Fix typo in domain for issue1280
On 2009/11/06 12:50:25, yangoon wrote:
> If you vote finally to include this patch, you should state clearly, that this
> is not the real fix, but a workaround to get it in release. And has to be
> removed with 1.6.

It will not have to be removed since this patch will not appear in the current
trunk (the patch for the trunk is to fix the xml file), this patch is only for
the 1.4 and 1.2 series.

Expand All Messages | Collapse All Messages