lgtm, perfect time to commit this before 2.0.0 is released. http://codereview.appspot.com/1496041/diff/1/23 File config/container.js (right): http://codereview.appspot.com/1496041/diff/1/23#newcode105 ...
15 years, 10 months ago
(2010-06-03 04:58:47 UTC)
#2
Should this change be included in the UPGRADING release note? I am sure some people ...
15 years, 10 months ago
(2010-06-03 17:44:42 UTC)
#3
Should this change be included in the UPGRADING release note?
I am sure some people modify/extend the DefaultUrlGenerator or implement their
own UrlGenerator implementation.
- Henry
Yes, keeping UPGRADING up to date should be required for these major architectural changes. I ...
15 years, 10 months ago
(2010-06-03 17:55:28 UTC)
#4
Yes, keeping UPGRADING up to date should be required for these major
architectural changes.
I know that I'll be making changes based on this CL...
On Jun 3, 2010, at 10:44 AM, henry.saputra@gmail.com wrote:
> Should this change be included in the UPGRADING release note?
>
> I am sure some people modify/extend the DefaultUrlGenerator or implement
> their own UrlGenerator implementation.
>
> - Henry
>
> http://codereview.appspot.com/1496041/show
Added UPGRADING comments and committed. The UPGRADING text is fairly sparse, but most people customizing ...
15 years, 10 months ago
(2010-06-03 18:44:26 UTC)
#6
Added UPGRADING comments and committed.
The UPGRADING text is fairly sparse, but most people customizing
UrlGenerator should be able to easily provide new impls.
On Fri, Jun 4, 2010 at 12:00 AM, John Hjelmstad <johnfargo@gmail.com> wrote:
> On Thu, Jun 3, 2010 at 10:28 AM, <lindner@inuus.com> wrote:
>
>> lgtm, perfect time to commit this before 2.0.0 is released.
>>
>>
>> http://codereview.appspot.com/1496041/diff/1/23
>> File config/container.js (right):
>>
>> http://codereview.appspot.com/1496041/diff/1/23#newcode105
>> config/container.js:105: "gadgets.uri.concat.host" :
>> "${Cur['defaultShindigTestHost']}",
>> we support templates here? interesting....
>
>
> I'm pretty sure we do anyway; the test broke for me before I tweaked this
> just so ;)
>
>
>>
>>
>> http://codereview.appspot.com/1496041/show
>>
>
>
Issue 1496041: Remove UrlGenerator
(Closed)
Created 15 years, 10 months ago by johnfargo
Modified 15 years, 9 months ago
Reviewers: shindig.remailer_gmail.com, Paul Lindner, henry.saputra
Base URL: http://svn.apache.org/repos/asf/shindig/trunk/
Comments: 1