Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(391)

Issue 1496041: Remove UrlGenerator (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 10 months ago by johnfargo
Modified:
15 years, 9 months ago
Reviewers:
Paul Lindner, henry.saputra, shindig.remailer
Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/
Visibility:
Public.

Description

This CL bites the bullet and removes all traces of the UrlGenerator interface from Shindig, instead favoring the replacement *UriManager classes.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -961 lines) Patch
config/container.js View 1 chunk +10 lines, -1 line 1 comment Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGuiceModule.java View 1 chunk +2 lines, -1 line 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultUrlGenerator.java View 1 chunk +0 lines, -203 lines 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/UrlGenerator.java View 1 chunk +0 lines, -65 lines 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/UrlValidationStatus.java View 1 chunk +0 lines, -25 lines 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/GadgetOAuthCallbackGenerator.java View 3 chunks +7 lines, -8 lines 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderingGadgetRewriter.java View 6 chunks +6 lines, -6 lines 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetRenderingServlet.java View 6 chunks +13 lines, -13 lines 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/JsServlet.java View 4 chunks +9 lines, -9 lines 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/JsonRpcHandler.java View 3 chunks +5 lines, -5 lines 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultJsUriManager.java View 1 chunk +1 line, -1 line 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/GlueUrlGenerator.java View 1 chunk +0 lines, -92 lines 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/DefaultGadgetSpecFactoryTest.java View 2 chunks +1 line, -5 lines 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/DefaultMessageBundleFactoryTest.java View 1 chunk +0 lines, -2 lines 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/DefaultUrlGeneratorTest.java View 1 chunk +0 lines, -255 lines 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth/GadgetOAuthCallbackGeneratorTest.java View 8 chunks +11 lines, -11 lines 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth/GadgetTokenStoreTest.java View 2 chunks +0 lines, -2 lines 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/render/RenderingGadgetRewriterTest.java View 5 chunks +7 lines, -27 lines 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetRenderingServletTest.java View 3 chunks +16 lines, -6 lines 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/HtmlAccelServletTest.java View 4 chunks +10 lines, -24 lines 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/JsonRpcHandlerTest.java View 5 chunks +9 lines, -27 lines 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/GlueUrlGeneratorTest.java View 1 chunk +0 lines, -173 lines 0 comments Download

Messages

Total messages: 6
johnfargo
15 years, 10 months ago (2010-06-03 03:21:16 UTC) #1
Paul Lindner
lgtm, perfect time to commit this before 2.0.0 is released. http://codereview.appspot.com/1496041/diff/1/23 File config/container.js (right): http://codereview.appspot.com/1496041/diff/1/23#newcode105 ...
15 years, 10 months ago (2010-06-03 04:58:47 UTC) #2
henry.saputra
Should this change be included in the UPGRADING release note? I am sure some people ...
15 years, 10 months ago (2010-06-03 17:44:42 UTC) #3
Paul Lindner
Yes, keeping UPGRADING up to date should be required for these major architectural changes. I ...
15 years, 10 months ago (2010-06-03 17:55:28 UTC) #4
johnfargo
On Thu, Jun 3, 2010 at 10:28 AM, <lindner@inuus.com> wrote: > lgtm, perfect time to ...
15 years, 10 months ago (2010-06-03 18:30:25 UTC) #5
johnfargo
15 years, 10 months ago (2010-06-03 18:44:26 UTC) #6
Added UPGRADING comments and committed.

The UPGRADING text is fairly sparse, but most people customizing
UrlGenerator should be able to easily provide new impls.

On Fri, Jun 4, 2010 at 12:00 AM, John Hjelmstad <johnfargo@gmail.com> wrote:

> On Thu, Jun 3, 2010 at 10:28 AM, <lindner@inuus.com> wrote:
>
>> lgtm, perfect time to commit this before 2.0.0 is released.
>>
>>
>> http://codereview.appspot.com/1496041/diff/1/23
>> File config/container.js (right):
>>
>> http://codereview.appspot.com/1496041/diff/1/23#newcode105
>> config/container.js:105: "gadgets.uri.concat.host" :
>> "${Cur['defaultShindigTestHost']}",
>> we support templates here?  interesting....
>
>
> I'm pretty sure we do anyway; the test broke for me before I tweaked this
> just so ;)
>
>
>>
>>
>> http://codereview.appspot.com/1496041/show
>>
>
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b