Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(343)

Issue 149160043: Remove trailing slashes ("/") in include lines. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 2 months ago by tonikitoo
Modified:
10 years, 1 month ago
Reviewers:
mallinath, perkj, mflodman, tkchin
Base URL:
https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git@master
Visibility:
Public.

Description

Remove trailing slashes ("/") in include lines. Some project whose packaging system is based on RPM use chromium as a browser. Modern RPM versions still ship a bug that causes the "path canonicalization" step to fail if there is a "trailing" slash ("\") character in a include line. e.g.: \#include "path//to/my/header." ^ This is a long standing problem tracked by RedHat in https://bugzilla.redhat.com/show_bug.cgi?id=304121 Error: [XXs] /usr/lib/rpm/debugedit: canonicalization unexpectedly shrank by one character [XXs] error: Bad exit status from /var/tmp/rpm-tmp.dFqmJQ (%install) Webrtc module has the only instance of a trailing slash in a include line, and I believe it is harmless to "fix" it. BUG=nobug

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M modules/video_render/incoming_video_stream.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5
tonikitoo
Guys, this is a *very* simple patch does not fix a problem in webrtc itself ...
10 years, 2 months ago (2014-09-28 23:34:30 UTC) #1
perkj
On 2014/09/28 23:34:30, tonikitoo wrote: > Guys, this is a *very* simple patch does not ...
10 years, 2 months ago (2014-09-29 08:29:27 UTC) #2
mflodman
Hi and thanks for the contribution! This patch should go into the WebRTC code and ...
10 years, 2 months ago (2014-09-29 08:32:47 UTC) #3
tonikitoo
On 2014/09/29 08:32:47, mflodman wrote: > Hi and thanks for the contribution! > > This ...
10 years, 1 month ago (2014-10-25 14:09:50 UTC) #4
perkj
10 years, 1 month ago (2014-10-28 08:49:41 UTC) #5
Sorry about the delay. Landed in
https://webrtc-codereview.appspot.com/27859004.



On Sat, Oct 25, 2014 at 4:09 PM, <a1.gomes@sisa.samsung.com> wrote:

> On 2014/09/29 08:32:47, mflodman wrote:
>
>> Hi and thanks for the contribution!
>>
>
>  This patch should go into the WebRTC code and then be pulled into
>>
> Chromium
>
>> rather than being submitted this way. See
>> http://www.webrtc.org/reference/getting-started for info around this.
>>
>
>  -Magnus
>>
>
> Hi Magnus/perkj.
>
> I've being having problems to get a full webrtc checkout (gclient sync
> hangs at "fetch chromium" step), and also it fails to "gcl upload".
>
> In the meanwhile please feel free to fix the issue, and even use my
> commit message as you like.
>
> it could even be a "TBR" commit I believe.
>
> Thanks!
>
> https://codereview.appspot.com/149160043/
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b