Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3)

Issue 1487041: Add sendmsg(), recvmsg(), recvmsg_into() methods to Python sockets

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by baikie
Modified:
5 years, 1 month ago
Reviewers:
Base URL:
http://svn.python.org/view/*checkout*/python/branches/py3k/
Visibility:
Public.

Description

From http://bugs.python.org/issue6560 Based on Heiko Wundram's patch from http://bugs.python.org/issue1194378

Patch Set 1 #

Total comments: 7

Patch Set 2 : Argh, I shouldn't have used quilt. Let's try that again. #

Patch Set 3 : Updated to use new BEGIN/END_SELECT_LOOP macros, fixed interrupted-timeout bug #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3142 lines, -0 lines) Patch
Doc/library/socket.rst View 1 2 4 chunks +176 lines, -0 lines 0 comments Download
Lib/ssl.py View 1 2 2 chunks +24 lines, -0 lines 0 comments Download
Lib/test/test_socket.py View 1 2 6 chunks +2120 lines, -0 lines 0 comments Download
Lib/test/test_ssl.py View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
Modules/socketmodule.c View 1 2 12 chunks +809 lines, -0 lines 0 comments Download

Messages

Total messages: 8
baikie
10 years, 8 months ago (2010-06-02 22:37:09 UTC) #1
Antoine Pitrou
Here is a couple of comments that came to my mind while reading the patch. ...
10 years, 7 months ago (2010-06-10 19:05:20 UTC) #2
baikie
Thanks for wading through the patch - especially all that test code. I've been testing ...
10 years, 7 months ago (2010-06-10 21:50:48 UTC) #3
Antoine Pitrou
I forgot one small thing. http://codereview.appspot.com/1487041/diff/1/5 File Lib/test/test_socket.py (right): http://codereview.appspot.com/1487041/diff/1/5#newcode1041 Lib/test/test_socket.py:1041: class TestError(Exception): You don't ...
10 years, 7 months ago (2010-06-12 17:18:21 UTC) #4
baikie
Here is a revised version of the patch. I've done some minor cleanup in the ...
10 years, 7 months ago (2010-06-13 19:49:48 UTC) #5
baikie
Revised version of patch
10 years, 7 months ago (2010-06-13 19:50:18 UTC) #6
baikie
Argh, I shouldn't have used quilt. Let's try that again.
10 years, 7 months ago (2010-06-13 19:56:52 UTC) #7
baikie
10 years, 1 month ago (2010-12-06 19:52:34 UTC) #8
Updated to use new BEGIN/END_SELECT_LOOP macros, fixed interrupted-timeout bug
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b