code review 148370043: os, syscall: add Unsetenv

src/os/env_test.go

 // Copyright 2010 The Go Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
 package os_test
 
 import (
         . "os"
         "reflect"
         "strings"
@@ skipping 52 matching lines @@
 func TestConsistentEnviron(t *testing.T) {
         e0 := Environ()
         for i := 0; i < 10; i++ {
                 e1 := Environ()
                 if !reflect.DeepEqual(e0, e1) {
                         t.Fatalf("environment changed")
                 }
         }
 }
 
-func TestUnsetEnv(t *testing.T) {

[r, 2014/10/01 02:13:02]

TestUnsetenv

-        const testKey = "TestUnsetEnv"

[r, 2014/10/01 02:13:03]

ditto

+func TestUnsetenv(t *testing.T) {
+        const testKey = "GO_TEST_UNSETENV"
         set := func() bool {
+                prefix := testKey + "="
                 for _, key := range Environ() {
-                        if strings.HasPrefix(key, testKey+"=") {
+                        if strings.HasPrefix(key, prefix) {
                                 return true
                         }
                 }
                 return false
         }
-        Setenv(testKey, "1")

[r, 2014/10/01 02:13:03]

check error

+        if err := Setenv(testKey, "1"); err != nil {
+                t.Fatalf("Setenv: %v", err)
+        }
         if !set() {
-                t.Fatal("Setenv didn't set TestUnsetEnv")
+                t.Error("Setenv didn't set TestUnsetenv")
         }
-        Unsetenv(testKey)

[r, 2014/10/01 02:13:03]

check error

+        if err := Unsetenv(testKey); err != nil {
+                t.Fatalf("Unsetenv: %v", err)
+        }
         if set() {
-                t.Fatal("Unsetenv didn't clear TestUnsetEnv")
+                t.Fatal("Unsetenv didn't clear TestUnsetenv")
         }
 }