Issue 14774045: Set TryJobResult.requester to request.user because auto_current_user_add doesn't work correctly in …

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14774045: Set TryJobResult.requester to request.user because auto_current_user_add doesn't work correctly in … (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by sullivan

Modified:
11 years, 10 months ago

Reviewers:
M-A

Visibility:
Public.

More Reviews

Description

Set TryJobResult.requester to request.user because auto_current_user_add doesn't work correctly in the /<issue>/try/<patchset> handler.

Patch Set 1 #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	codereview/views_chromium.py	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

sullivan

On 2013/10/17 17:08:00, M-A wrote: > in … ? > > lgtm but please expand ...

11 years, 10 months ago (2013-10-17 17:10:54 UTC) #3

M-A

11 years, 10 months ago (2013-10-17 17:16:23 UTC) #4

On 2013/10/17 17:10:54, sullivan wrote:
> On 2013/10/17 17:08:00, M-A wrote:
> > in … ?
> > 
> > lgtm but please expand the CL description.
> 
> Sorry I missed that. description updated.
> 
> If you're okay with the description, I have a silly question: how do I submit?

I tweaked it more to fit the skeleton
"""
<summary>

<description>
"""

Committed as 23416282ce05 and live.

Expand All Messages | Collapse All Messages